Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue numbers not linked in commits list #8042

Closed
2 of 8 tasks
dunderpate opened this issue Aug 30, 2019 · 4 comments
Closed
2 of 8 tasks

Issue numbers not linked in commits list #8042

dunderpate opened this issue Aug 30, 2019 · 4 comments
Labels
issue/stale type/enhancement An improvement of existing functionality

Comments

@dunderpate
Copy link

  • Gitea version (or commit ref): 1.9.0-dev built with go1.12.6
  • Git version: 2.22.0
  • Operating system: FreeBSD 12.0-RELEASE r341666 GENERIC amd64
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
    • https://try.gitea.io was down at the time this issue was authored
  • Log gist:

Description

I have an external issue tracker configured in a repository's settings, however the commits list messages don't have the issue number hyperlinked. I can confirm that the issue number is being linked properly when viewing a specific commit though. Please see the attached images for context.

If there is anymore information I can provide, feel free to let me know.

Thanks everyone!

Screenshots

What I see in the commits list (incorrect)

link_issue_commits_before

What I expect to see in the commits list (correct)

link_issue_commits_after

What I see on the commit page (correct)

link_issue_commit_working

@gary-kim
Copy link
Member

Currently, those are not made into links.
@lafriks I remember you said there were issues with making links in pages such as the ones referenced. Should we look into fixing them for the 1.11 release?

@dunderpate
Copy link
Author

Makes sense @gary-kim, I'm guessing it's performance related? In any case, thanks for the context. I'll wait to hear what comes out of the discussion.

@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 6, 2019
@stale
Copy link

stale bot commented Nov 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 5, 2019
@lafriks
Copy link
Member

lafriks commented Nov 5, 2019

This is already fixed in 1.10 release

@lafriks lafriks closed this as completed Nov 5, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants