Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed URLs in the API git/commits end point for trees #7564

Closed
richmahn opened this issue Jul 22, 2019 · 0 comments · Fixed by #7565
Closed

Malformed URLs in the API git/commits end point for trees #7564

richmahn opened this issue Jul 22, 2019 · 0 comments · Fixed by #7565
Labels
Milestone

Comments

@richmahn
Copy link
Contributor

richmahn commented Jul 22, 2019

In 1.9-rc2 (and 1.10-dev):

In a the response for the http://locahost:3000/api/v1/repos/<owner>/<repo>/git/commits/<hash> there are a bad URLs, one for the HTML Url, the other for the trees URL. Example:

{
  ...
  "html_url": "http://localhost:3000/testuser/testrepo/commits/6691301cf8fb73e57206ea5430003dd296764111",
  ...
  "tree": {
      "url": "http://localhost:3000/api/v1/repos/testuser/testrepo/trees/6691301cf8fb73e57206ea5430003dd296764111",
      "sha": "6691301cf8fb73e57206ea5430003dd296764111"
    }
  ...
}

It should be commit and not commits, /git/treesnot just/trees`, respectively.

@richmahn richmahn changed the title Malformed URL in the API git/commits end point for trees Malformed URLs in the API git/commits end point for trees Jul 22, 2019
richmahn added a commit to richmahn/gitea that referenced this issue Jul 22, 2019
@lafriks lafriks added this to the 1.9.0 milestone Jul 22, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants