Collaborators in repositories in private organisations cannot access repository

[zeripath]

• Gitea version (or commit ref): 1.9.0+dev-257-g7dd983797
• Git version: N/A
• Operating system:
• Database (use [x]):
  • PostgreSQL - probably also
  • MySQL
  • MSSQL - probably also
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL) https://try.gitea.io/TestOrgAnother/repository-with-collaborator
  • No
  • Not relevant
• Log gist:

Description

If I create a repository in a private organization and add a collaborator who is not a member of that organization they cannot access the repository despite it being it appearing on their dashboard.

Screenshots

[mrsdizzie]

This seems to be from @lunny PR #6743

gitea/models/repo_permission.go

Lines 171 to 174 in 7dd9837

	if repo.Owner.IsOrganization() && !HasOrgVisible(repo.Owner, user) {
	perm.AccessMode = AccessModeNone
	return
	}

Maybe there needs to be a check here if they are a collaborator (similar as below) and set access perms/not return if so?