Too long description of organizations breaks UI

[shaoran]

• Gitea version (or commit ref): 1.8.0 (https://dl.gitea.io/gitea/1.8.0/gitea-1.8.0-linux-amd64.xz)
• Git version: 2.11.0
• Operating system: Debian 9
• Database (use [x]):
  • SQLite

Description

• create a new organization and/or edit an existing one
• In the description field use more than 254 characters
• click on update setting

You'll get the following error:

template: org/settings/options:41:110: executing "org/settings/options" at <eq .CurrentVisibility 0>: error calling eq: invalid type for comparison

The text field should allow max. 254 characters or the description in the database should allow more characters.

[adelowo]

I cannot replicate this. There is actually validation in place to protect against this kind of thing.

@shaoran How were you able to make a description of more than 254 characters

[mrsdizzie]

@adelowo that is the repo description -- this error is about the description of an org: if you go to https://example.com/org/orgname/settings you can see.

[adelowo]

Damn... I haven't had enough water today :)

Will take a look at it

[shaoran]

@adelowo no problem, we all do mistakes. To answer your question, I copied and pasted a couple of paragraphs (3 to be precise) from our company homepage, that leads to more than 255 characters.

[mrsdizzie]

it looks like updating an org settings is maybe missing helper functions to check these types of things similar to what repos and org_teams have:

gitea/models/repo.go

Line 1675 in 81059a2

func updateRepository(e Engine, repo *Repository, visibilityChanged bool) (err error) {

gitea/models/org_team.go

Line 370 in 81059a2

// UpdateTeam updates information of team.

Updating an org uses updateUser:

gitea/models/user.go

Lines 971 to 974 in 81059a2

	func updateUser(e Engine, u *User) error {
	_, err := e.ID(u.ID).AllCols().Update(u)
	return err
	}

But the truncating for a user happens in this BeforeUpdate:

gitea/models/user.go

Line 156 in 81059a2

// BeforeUpdate is invoked from XORM before updating this object.

Which maybe doesn't happen for an org. I'm not totally familiar with how it all works though

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[Cherrg]

This also affects the organisation name if there are added more than 40 letters

[Cherrg]

Which maybe doesn't happen for an org. I'm not totally familiar with how it all works though

@mrsdizzie JFYI: I found, that organisations are nearly the same as users, they share the same model. It's a flag, so these update functions got called. It was just a missing variable for template.