Error message should have given better error message on what is wrong at least if there is any minimum

[boskiv]

• Gitea version (or commit ref): 321cc2a
• Git version: -
• Operating system: docker
• Database (use [x]):
  • [ x ] PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • [ x ] Not relevant
• Log gist:
  https://gist.github.com/boskiv/cffeafcba8dc8b46fa7e095266f1ef25

Description

Changing mirror interval to 5m , raise non-informal message
Minimum available interval 10m

Screenshots

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[Ryuno-Ki]

The minimum interval is depending on a setting:

gitea/routers/web/repo/setting.go

Lines 190 to 203 in 73382d2

	interval, err := time.ParseDuration(form.Interval)
	if err != nil || (interval != 0 && interval < setting.Mirror.MinInterval) {
	ctx.Data["Err_Interval"] = true
	ctx.RenderWithErr(ctx.Tr("repo.mirror_interval_invalid"), tplSettingsOptions, &form)
	} else {
	ctx.Repo.Mirror.EnablePrune = form.EnablePrune
	ctx.Repo.Mirror.Interval = interval
	ctx.Repo.Mirror.ScheduleNextUpdate()
	if err := repo_model.UpdateMirror(ctx, ctx.Repo.Mirror); err != nil {
	ctx.Data["Err_Interval"] = true
	ctx.RenderWithErr(ctx.Tr("repo.mirror_interval_invalid"), tplSettingsOptions, &form)
	return
	}
	}

and

gitea/routers/web/repo/setting.go

Lines 319 to 324 in 73382d2

	interval, err := time.ParseDuration(form.PushMirrorInterval)
	if err != nil || (interval != 0 && interval < setting.Mirror.MinInterval) {
	ctx.Data["Err_PushMirrorInterval"] = true
	ctx.RenderWithErr(ctx.Tr("repo.mirror_interval_invalid"), tplSettingsOptions, &form)
	return
	}

The translation key is "repo.mirror_interval_invalid". See its translation

gitea/options/locale/locale_en-US.ini

Line 864 in 73382d2

mirror_interval_invalid = The mirror interval is not valid.

I don't know, how to inject a value (the configured minimum interval) there.

[Ryuno-Ki]

Thanks, @zeripath