Skip to content

Minor visual glitch with file icon in comments #32316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KazzmanK opened this issue Oct 22, 2024 · 5 comments · Fixed by #32319
Closed

Minor visual glitch with file icon in comments #32316

KazzmanK opened this issue Oct 22, 2024 · 5 comments · Fixed by #32319
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.22.4

Comments

@KazzmanK
Copy link
Contributor

Description

If I have a post with file attached, while editing post attachment`s part have wrong file icon

After I exit edit mode icon becomes normal

Screenshots

Edit post mode
image

View mode
image

Gitea Version

1.22.3

Can you reproduce the bug on the Gitea demo site?

No

Operating System

No response

Browser Version

120
@KazzmanK KazzmanK added topic/ui Change the appearance of the Gitea UI type/bug labels Oct 22, 2024
@lunny
Copy link
Member

lunny commented Oct 22, 2024

Can you reproduce this on demo site? It maybe related to your configuration.

@lunny lunny added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Oct 22, 2024
@yp05327
Copy link
Contributor

yp05327 commented Oct 22, 2024 •
edited
Loading

I can reproduce it.

The first time you uploaded it, src is empty.
image
image

Then save it and edit again, the image src is the attachment
image

@yp05327 yp05327 removed the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Oct 22, 2024
@lunny
Copy link
Member

lunny commented Oct 22, 2024

OK. When uploading a non-image file?

@yp05327
Copy link
Contributor

yp05327 commented Oct 22, 2024 •
edited
Loading

Yes, if it is a image, it works.

@yp05327
Copy link
Contributor

yp05327 commented Oct 22, 2024 •
edited
Loading

Comes from:
image

Maybe we need to add a file extension check here.

@yp05327 yp05327 mentioned this issue Oct 23, 2024
Merged
@lunny lunny added this to the 1.22.4 milestone Oct 23, 2024
lunny pushed a commit to lunny/gitea that referenced this issue Oct 26, 2024
@yp05327 @lunny
Fix broken image when editing comment with non-image attachments (go-…
0102ff6 
…gitea#32319)

Fix go-gitea#32316
@lunny lunny mentioned this issue Oct 26, 2024
Merged
lunny added a commit that referenced this issue Nov 2, 2024
@lunny @yp05327
Fix broken image when editing comment with non-image attachments (#32319
a3b7b98 
) (#32345)

Backport #32319 

Fix #32316

---------

Co-authored-by: yp05327 <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.4
Development

Successfully merging a pull request may close this issue.

Fix broken image when editing comment with non-image attachments yp05327/gitea
3 participants
@lunny @KazzmanK @yp05327