Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken styles on hover in activity #30808

Closed
stuzer05 opened this issue May 1, 2024 · 7 comments · Fixed by #30823
Closed

broken styles on hover in activity #30808

stuzer05 opened this issue May 1, 2024 · 7 comments · Fixed by #30823
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@stuzer05
Copy link

stuzer05 commented May 1, 2024

Description

image

both on main screen and profile

Gitea Version

trunk

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None
@stuzer05 stuzer05 changed the title brokrn styles on hover in activity broken styles on hover in activity May 1, 2024
@wxiaoguang
Copy link
Contributor

It's related to the tippy style change @silverwind

@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label May 2, 2024
@silverwind
Copy link
Member

silverwind commented May 2, 2024 •
edited
Loading

Yes, this is related to the removal of the default 1rem padding. Will check.

@silverwind
Copy link
Member

silverwind commented May 2, 2024 •
edited
Loading

Problem is, this lib does not expose any way to allow modifying these tippy instances:

https://github.com/razorness/vue3-calendar-heatmap/blob/955626176cb5dc3d3ead8120475c2e5e753cc392/src/components/CalendarHeatmap.vue#L200-L204

And even if I raise a PR, it seems likely it's not going to be merged anytime soon.

@silverwind
Copy link
Member

So I think the proper solution is to pass tooltip=false to the lib and instantiate our own tippy.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 2, 2024 •
edited
Loading

So I think the proper solution is to pass tooltip=false to the lib and instantiate our own tippy.

That's what I said in #30732 (comment) : I still do not think it is safe to backport.

Now we have limited time to fix this new regression.

@silverwind
Copy link
Member

It's fine, it's a minor cosmetical issue.

@silverwind silverwind mentioned this issue May 2, 2024
Closed
@wxiaoguang
Copy link
Contributor

I also proposed one. Fix activity heat map padding & locale #30823

@wxiaoguang wxiaoguang mentioned this issue May 2, 2024
Merged
wxiaoguang added a commit that referenced this issue May 2, 2024
@wxiaoguang @silverwind
Fix activity heat map padding & locale (#30823)
eb8bb82 
Fix #30808

---------

Co-authored-by: silverwind <[email protected]>
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 2, 2024
@wxiaoguang @silverwind @GiteaBot
Fix activity heat map padding & locale (go-gitea#30823)
78dd9ba 
Fix go-gitea#30808

---------

Co-authored-by: silverwind <[email protected]>
@GiteaBot GiteaBot mentioned this issue May 2, 2024
Merged
wxiaoguang added a commit that referenced this issue May 2, 2024
@GiteaBot @wxiaoguang @silverwind
Fix activity heat map padding & locale (#30823) (#30827)
606b12c 
Backport #30823 by wxiaoguang

Fix #30808

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: silverwind <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
4 participants
@silverwind @wxiaoguang @yp05327 @stuzer05