Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript error: $detailModal.find is not a function #30434

Closed
yp05327 opened this issue Apr 12, 2024 · 1 comment · Fixed by #30450
Closed

JavaScript error: $detailModal.find is not a function #30434

yp05327 opened this issue Apr 12, 2024 · 1 comment · Fixed by #30450
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Apr 12, 2024

Description

image
click details button, you will see this error
caused by #30115

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

@yp05327 yp05327 added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 12, 2024
@lunny lunny added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Apr 12, 2024
@silverwind
Copy link
Member

My bad, should have seen this during review.

lunny pushed a commit that referenced this issue Apr 13, 2024
Fix #30434, regression from
#30115.

I also removed the date insertion into the modal which was also broken
since that date was switched to `absolute-date` because I see no real
purpose to putting that date into the modal.

Result:

<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/aa2eb8b4-73dc-4d98-9b80-3f276f89d9e5">
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Apr 13, 2024
Fix go-gitea#30434, regression from
go-gitea#30115.

I also removed the date insertion into the modal which was also broken
since that date was switched to `absolute-date` because I see no real
purpose to putting that date into the modal.

Result:

<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/aa2eb8b4-73dc-4d98-9b80-3f276f89d9e5">
silverwind added a commit that referenced this issue Apr 13, 2024
Backport #30450 by @silverwind

Fix #30434, regression from
#30115.

I also removed the date insertion into the modal which was also broken
since that date was switched to `absolute-date` because I see no real
purpose to putting that date into the modal.

Result:

<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/aa2eb8b4-73dc-4d98-9b80-3f276f89d9e5">

Co-authored-by: silverwind <[email protected]>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 16, 2024
Fix go-gitea/gitea#30434, regression from
go-gitea/gitea#30115.

I also removed the date insertion into the modal which was also broken
since that date was switched to `absolute-date` because I see no real
purpose to putting that date into the modal.

Result:

<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/aa2eb8b4-73dc-4d98-9b80-3f276f89d9e5">

(cherry picked from commit 8fd8978b4934865c2b041216e84e923ad574a4c7)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 16, 2024
Backport #30450 by @silverwind

Fix go-gitea/gitea#30434, regression from
go-gitea/gitea#30115.

I also removed the date insertion into the modal which was also broken
since that date was switched to `absolute-date` because I see no real
purpose to putting that date into the modal.

Result:

<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/aa2eb8b4-73dc-4d98-9b80-3f276f89d9e5">

Co-authored-by: silverwind <[email protected]>
(cherry picked from commit fd2184e2343842e158f5b12e3d2e5b88effea2fd)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants