Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Makefile dependencies #2198

Closed
silverwind opened this issue Jul 22, 2017 · 7 comments
Closed

Document Makefile dependencies #2198

silverwind opened this issue Jul 22, 2017 · 7 comments
Labels
type/docs This PR mainly updates/creates documentation

Comments

@silverwind
Copy link
Member

Description

The Makefile has various dependencies on command line tools which should be documented as a requirement for developing Gitea. I'm thinking this should be in a file in the repository itself and not on the website, maybe in CONTRIBUTING.md or README.md.
@silverwind silverwind mentioned this issue Jul 22, 2017
Merged
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Jul 22, 2017
@lafriks
Copy link
Member

lafriks commented Jul 22, 2017

I think CONTRIBUTING.md would be best place for this

@bkcsoft
Copy link
Member

bkcsoft commented Jul 26, 2017

@silverwind Do you have a list of those? If you're referring to various go get then those should be fetched automagically if they don't exist

@sapk
Copy link
Member

sapk commented Jul 26, 2017

Looking quickly at makefile most (every ?) of deps are go project that are go get. (gocovmerge is used but not go get, we should fix this). But we could still list them in CONTRIBUTING.md at least to give credits and explain for what we use them.

@sapk
Copy link
Member

sapk commented Jul 26, 2017 •
edited
Loading

And looking at #2194 ref. I think this PR is mostly for inkscape/convert/... new deps.

@lafriks
Copy link
Member

lafriks commented Jul 26, 2017

@sapk not only, for development there is also make and golang dependency ;)

@silverwind
Copy link
Member Author

I think these are all that are not pulled via go get:

git, gocovmerge, lessc, inkscape, ImageMagick, zopflipng

Can gocovmerge be installed via go get, by the way?

@sapk sapk mentioned this issue Jul 30, 2017
Merged
@sapk
Copy link
Member

sapk commented Jul 30, 2017

I have done a PR to fix gocovmerge. Lessc is based on a go version that is go get.

lafriks pushed a commit to silverwind/gitea that referenced this issue Sep 20, 2017
@silverwind @lafriks
Use standard lessc and minify CSS using Node.js
6641d72 
This changes the previous nonstandard `lessc` to the official one and
enables CSS minification via the clean-css module.

To build CSS, Node.js is required along with a `npm install` to get the
tools installed locally in node_modules so there is no dependency on
binaries in PATH. Benefits include:

- Allows one to have a standard lessc in PATH.
- Can now use command line switches on lessc.
- Minified CSS brings faster page load times and also has the benefit
  of discouraging contributors from editing CSS directly.

To build CSS, Node.js is required along with a `npm install` to get the
tools installed locally based on the information in `package.json`.

The 'make stylesheet' task was modified to run without condition. This
makes it easier to work on the make task itself without having to delete
files.

Also fixes: go-gitea#2198
@lunny lunny closed this as completed in 1fbfccb Sep 21, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@silverwind @lafriks @sapk @bkcsoft