You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Site throws 404 for certain branches after an attempt to display a compare page within a repo. A repo of which you're not the owner but have the right to create pull requests. Steps to reproduce the error:
Create an organization with some repo to which you have write access.
Create a branch directly in the repository (not by fork) and make some changes.
Push the changes remote, so that it's available on gitea.
Click compare branches below the repo description to open the compare page.
After the 4th step, a 404 should be thrown. What frontend tries to do is to assume that we would always merge from a fork, not directly on the repo, so it provides wrong upstream path, e.g.
organization:master..username:branch
instead of just
organization:master..branch
What it should do is to check whether the currently viewed repo is a fork. If it is, pass the first option. If not, pass the second one.
I will drop a fix for that in a matter of minutes. ✌
The text was updated successfully, but these errors were encountered:
* Make compare button URL aware if current repo is a fork (#2162)
* Optimize code
* To not change current behaviour check if signed in user has fork of base repository
* Fix to check only if signed user has forked repo otherwise it will still redirect to wrong page
Site throws 404 for certain branches after an attempt to display a compare page within a repo. A repo of which you're not the owner but have the right to create pull requests. Steps to reproduce the error:
After the 4th step, a 404 should be thrown. What frontend tries to do is to assume that we would always merge from a fork, not directly on the repo, so it provides wrong upstream path, e.g.
instead of just
What it should do is to check whether the currently viewed repo is a fork. If it is, pass the first option. If not, pass the second one.
I will drop a fix for that in a matter of minutes. ✌
The text was updated successfully, but these errors were encountered: