Topics Save Button uses href with javascript protocol

[Ryuno-Ki]

Description

I noticed this while working on #19900.

In general, href="javascript:;" is an anti-pattern (see http://www.jibbering.com/faq/#javascriptURI for the original intent).
As a rule of thumb, links go somewhere and buttons are used to resolve actions.

gitea/templates/repo/home.tmpl

Lines 48 to 49 in d9b50e4

	<a class="ui button primary" href="javascript:;" id="save_topic"
	data-link="{{.RepoLink}}/topics">{{.i18n.Tr "repo.topic.done"}}</a>

is the only occurence I could find so far. Since it is controlled by JavaScript alone, a fix would require the <a> to become <button type="button"> (or perhaps a submit button if there would be a <form> and Go-side logic to update the saved topics).
Plus some style changes to make it look like before.

Gitea Version

1.17.0+dev-675-g81cf00686

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

try.gitea.io

Database

No response

[wxiaoguang]

There could be a lot of bad smells in a large project which is many years old ..... so, large projects always need maintaining and refactoring.

And I think the AJAX was used there to avoid page reload/refresh, just like what GitHub does, it seems no benefit to replace it with a form.

[silverwind]

Proper solution is probably <a role="button">.