When selecting a license you can't write in any field #15172
Comments
|
Can't reproduce in latest firefox. Which browser are you using? Did you try clearing the browser cache? Are there errors in JS concole? |
|
Curious it happens to me in Edge, Chrome and Opera, I just installed Opera to test it |
|
Indeed, looks like only FF is unaffected. |
|
1a03fa7 is the bad commit. |
|
Hmm I think the only related upgrade there is jQuery which did some changes with focus events which may trigger this bug in Fomantic's form handling. Should try if reverting jQuery to 3.5.1 fixes this, and if so, report issue to Fomantic. https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/ If it isn't the jQuery update, maybe some other frontend dependency is interfering since the upgrade. |
|
Dependabot made a PR to upgrade to jquery v3.6 but they haven't approved it yet We should go back to jquery v3.5.1 and the problem should be fixed. |
|
Also one needs to consider our hard-fork version of semantic's dropdown module which could also be the source of the error. I guess it's time to finally drop it if it's indicated as the source of the error. |
|
So it seems both downgrading jQuery and removing the hard-fork seem to resolve the issue. I'll go with the latter as it also removes 150kB frontend and it's something I've been meaning to do for a while now. It does mean dropdowns will be slightly less accessible but I think such changes are better done upstream anyways. |
jQuery 3.6.0 seems to have broke the dropdown focus handling (focus would get stuck on the dropdown) in this module which we have vendored on top of fomantic for accessibility improvements. Either downgrading jQuery to 3.5.1 or removing the vendor copy seems to resolve the issue and I opted for removing the copy because I think such changes should be done upstream and the removal also lightens the JS by 155kB before minify/gzip. Fixes: go-gitea#15172
jQuery 3.6.0 seems to have broke the dropdown focus handling (focus would get stuck on the dropdown) in this module which we have vendored on top of fomantic for accessibility improvements. Either downgrading jQuery to 3.5.1 or removing the vendor copy seems to resolve the issue and I opted for removing the copy because I think such changes should be done upstream and the removal also lightens the JS by 155kB before minify/gzip. Fixes: #15172 Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>
|
I tried with a simple form containing a dropdown using jquery 3.6.0 and latest fomantic 2.8.8-beta Could you please adjust my jsfiddle (if possible) to be able to reproduce the situation in gitea? I am otherwise about to merge the jquery 3.6.0 dependency into fomantic |
|
I think there is indeed no issue with jQuery 3.6.0 with the latest fomantic |
This PR restores the vendored and patched dropdow from go-gitea#8638. It however, abandons the calls to `click()` using instead the default dropdown click calls instead. This prevents the issue of the dropdown grabbing focus permanently however, this may have negative effects on the effect of focus on the dropdowns. Of note, the behaviour of the template selector dropdown on the repo creation page is slightly odd - I don't believe that this odd behaviour is caused by this PR but rather by the feed source for this. I suspect that the dropdown should be adding a delete button to its selection. Fix go-gitea#15172 References: go-gitea#7057 Signed-off-by: Andrew Thornton <[email protected]>
…tea#16576) Backport go-gitea#16576 This PR restores the vendored and patched dropdow from go-gitea#8638. It however, it partially abandons the call to `click()` using instead the default dropdown click calls instead. This prevents the issue of the dropdown grabbing focus permanently however, this may have negative effects on the effect of focus on the dropdowns. Of note, the behaviour of the template selector dropdown on the repo creation page is slightly odd - I don't believe that this odd behaviour is caused by this PR but rather by the feed source for this. I suspect that the dropdown should be adding a delete button to its selection. Fix go-gitea#15172 References: go-gitea#7057 Signed-off-by: Andrew Thornton <[email protected]>
Backport #16576 This PR restores the vendored and patched dropdow from #8638. It however, it partially abandons the call to `click()` using instead the default dropdown click calls instead. This prevents the issue of the dropdown grabbing focus permanently however, this may have negative effects on the effect of focus on the dropdowns. Of note, the behaviour of the template selector dropdown on the repo creation page is slightly odd - I don't believe that this odd behaviour is caused by this PR but rather by the feed source for this. I suspect that the dropdown should be adding a delete button to its selection. Fix #15172 References: #7057 Signed-off-by: Andrew Thornton <[email protected]>
* Restore #10096/#8638 and re-fix #15172 This PR restores the vendored and patched dropdow from #8638. It however, abandons the calls to `click()` using instead the default dropdown click calls instead. This prevents the issue of the dropdown grabbing focus permanently however, this may have negative effects on the effect of focus on the dropdowns. Of note, the behaviour of the template selector dropdown on the repo creation page is slightly odd - I don't believe that this odd behaviour is caused by this PR but rather by the feed source for this. I suspect that the dropdown should be adding a delete button to its selection. Fix #15172 References: #7057 Signed-off-by: Andrew Thornton <[email protected]> * leverage fomantic-build instead Signed-off-by: Andrew Thornton <[email protected]> * as per jookia Signed-off-by: Andrew Thornton <[email protected]>
jQuery 3.6.0 seems to have broke the dropdown focus handling (focus would get stuck on the dropdown) in this module which we have vendored on top of fomantic for accessibility improvements. Either downgrading jQuery to 3.5.1 or removing the vendor copy seems to resolve the issue and I opted for removing the copy because I think such changes should be done upstream and the removal also lightens the JS by 155kB before minify/gzip. Fixes: go-gitea#15172 Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>
When you try to create a repository and select a license you cannot continue working in the other fields.
I checked the bug in try.gitea.io v1.15.0+dev-27-gdc56fb7c8
The text was updated successfully, but these errors were encountered: