Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner UI for explore page #1253

Closed
pgaskin opened this issue Mar 14, 2017 · 15 comments
Closed

Cleaner UI for explore page #1253

pgaskin opened this issue Mar 14, 2017 · 15 comments
Labels
topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Milestone

Comments

@pgaskin
Copy link
Contributor

pgaskin commented Mar 14, 2017

Does anyone else like my cleaner design? If so, I will submit a PR.

Screenshots on try.gitea.io

Old New
screenshot_00005 screenshot_00004
screenshot_00007 screenshot_00006
screenshot_00009 screenshot_00008
@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 14, 2017

How I did it:

  1. Move content and menu out of grid
  2. Menu css: justify-content: center;margin-bottom: 10px;
  3. Menu classes: ui secondary pointing tabular top attached borderless menu navbar
  4. Remove explore: header from menu

To make it look like this so you can try it, use the following js (yes, I know it does not do the exact changes above, but it essentially does the same thing):

$(".explore>.ui.container>.ui.grid").removeClass("grid");
$(".four.wide.column>.menu").attr("style", "justify-content: center;margin-bottom: 10px;").attr("class", "ui secondary pointing tabular top attached borderless menu navbar");
$(".ui.menu .header.item").remove();

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 14, 2017

This modification will also make the ui look better on smaller screens.

@tboerger
Copy link
Member

Basically it looks better, but the horizontal nav can be done better

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 14, 2017

@tboerger What should I change?

@tboerger
Copy link
Member

Maybe a different background on the full width for this top navigation

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 14, 2017

@tboerger Like this:
screenshot_00011

After moving it above the .ui.container, I added the css:

justify-content: center;
padding-top: 15px;
margin-top: -15px;
margin-bottom: 15px;
background-color: #FAFAFA;
border-width: 1px;

UPDATED: according to the next comment

@tboerger
Copy link
Member

Yes, and maybe more space around the search

@tboerger
Copy link
Member

I can't remember the html structure, but is it easily possible to list two columns on large displays?

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 14, 2017

@tboerger Done, see new screenshot

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 14, 2017

@tboerger not easily

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 14, 2017

@tboerger Should I submit a PR now?

@pgaskin pgaskin mentioned this issue Mar 14, 2017
@tboerger
Copy link
Member

From my side: yes.

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 14, 2017

#1255

@lunny lunny added this to the 1.2.0 milestone Mar 15, 2017
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. topic/ui Change the appearance of the Gitea UI labels Mar 15, 2017
@lcges
Copy link

lcges commented Mar 15, 2017

In general is good.
@geek1011 what do you think about split in half use Grids, sections: user, organization, repository)?
Will be better filled free space.

@lunny
Copy link
Member

lunny commented Mar 15, 2017

Maybe aligned left is better.

bkcsoft pushed a commit that referenced this issue Mar 15, 2017
* Take navbar out of column
* Add styles to navbar
* Changed navbar classes
* Remove unneeded !important from index.css
* Remove unneeded !important from _explore.less
@pgaskin pgaskin closed this as completed Mar 15, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants