Fix deleted milestone bug

go-gitea · Jun 15, 2017 · 2e5dee4 · 2e5dee4
1 parent b7d597e
commit 2e5dee4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/models/issue_comment.go b/models/issue_comment.go
@@ -228,15 +228,14 @@ func (c *Comment) LoadLabel() error {
 func (c *Comment) LoadMilestone() error {
 	if c.OldMilestoneID > 0 {
 		var oldMilestone Milestone
-		has, err := x.ID(c.OldMilestoneID).Get(&oldMilestone)
+		has, err := x.ID(c.OldMilestoneID).Get(oldMilestone)
 		if err != nil {
 			return err
 		} else if !has {
-			return ErrMilestoneNotExist{
-				ID: c.OldMilestoneID,
-			}
+			c.OldMilestone = NewGhostMilestone()
+		} else {
+			c.OldMilestone = &oldMilestone
 		}
-		c.OldMilestone = &oldMilestone
 	}
 
 	if c.MilestoneID > 0 {
@@ -245,11 +244,10 @@ func (c *Comment) LoadMilestone() error {
 		if err != nil {
 			return err
 		} else if !has {
-			return ErrMilestoneNotExist{
-				ID: c.MilestoneID,
-			}
+			c.Milestone = NewGhostMilestone()
+		} else {
+			c.Milestone = &milestone
 		}
-		c.Milestone = &milestone
 	}
 	return nil
 }

diff --git a/models/issue_milestone.go b/models/issue_milestone.go
@@ -119,6 +119,14 @@ func NewMilestone(m *Milestone) (err error) {
 	return sess.Commit()
 }
 
+// NewGhostMilestone a fake milestone to hold the place of a deleted milestone
+func NewGhostMilestone() *Milestone {
+	return &Milestone{
+		ID:   -1,
+		Name: "Deleted",
+	}
+}
+
 func getMilestoneByRepoID(e Engine, repoID, id int64) (*Milestone, error) {
 	m := &Milestone{
 		ID:     id,