Fix null pointer dereference in ParseCommitWithSignature (#4962)

go-gitea · Sep 20, 2018 · 043ab2c · 043ab2c
1 parent 8b113cd
commit 043ab2c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/models/gpg_key.go b/models/gpg_key.go
@@ -360,7 +360,7 @@ func verifySign(s *packet.Signature, h hash.Hash, k *GPGKey) error {
 
 // ParseCommitWithSignature check if signature is good against keystore.
 func ParseCommitWithSignature(c *git.Commit) *CommitVerification {
-	if c.Signature != nil {
+	if c.Signature != nil && c.Committer != nil {
 		//Parsing signature
 		sig, err := extractSignature(c.Signature.Signature)
 		if err != nil { //Skipping failed to extract sign