Gitlab Migrator: dont ignore reactions of last request (#16903) (#16913)

Backport #16903 Fix bug related to early breaking when migrating reactions. Co-authored-by: 6543 <[email protected]>
go-gitea · Sep 1, 2021 · 02de432 · 02de432
1 parent f949f9e
commit 02de432
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/modules/migrations/gitlab.go b/modules/migrations/gitlab.go
@@ -396,12 +396,15 @@ func (g *GitlabDownloader) GetIssues(page, perPage int) ([]*base.Issue, bool, er
 			if err != nil {
 				return nil, false, fmt.Errorf("error while listing issue awards: %v", err)
 			}
-			if len(awards) < perPage {
-				break
-			}
+
 			for i := range awards {
 				reactions = append(reactions, g.awardToReaction(awards[i]))
 			}
+
+			if len(awards) < perPage {
+				break
+			}
+
 			awardPage++
 		}
 
@@ -558,12 +561,15 @@ func (g *GitlabDownloader) GetPullRequests(page, perPage int) ([]*base.PullReque
 			if err != nil {
 				return nil, false, fmt.Errorf("error while listing merge requests awards: %v", err)
 			}
-			if len(awards) < perPage {
-				break
-			}
+
 			for i := range awards {
 				reactions = append(reactions, g.awardToReaction(awards[i]))
 			}
+
+			if len(awards) < perPage {
+				break
+			}
+
 			awardPage++
 		}