Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid github.com/go-delve/liner version #3025

Closed
pboguslawski opened this issue Jun 2, 2022 · 3 comments · Fixed by #3026
Closed

Invalid github.com/go-delve/liner version #3025

pboguslawski opened this issue Jun 2, 2022 · 3 comments · Fixed by #3026

Comments

@pboguslawski
Copy link

delve/go.mod

Line 10 in 9c5777e

github.com/go-delve/liner v1.2.2-1

There is no v1.2.2-1 tag in

https://github.com/go-delve/liner/tags

@pboguslawski
Copy link
Author

Seems that after golang/go#51312 (comment) go does not treat branches with semantic-version names as releases.

go.mod points now to github.com/go-delve/liner version v1.2.2-1 but is a branch name not tag; this causes go 1.18 errors like

$ export GOPROXY=direct
$ go get github.com/go-delve/[email protected]
go: github.com/go-delve/[email protected]: invalid version: resolves to version v1.2.3-0.20220127212407-d32d89dd2a5d (v1.2.2-1 is not a tag)

Using default goproxy does not return error (maybe tag was cached before changes):

$ export GOPROXY=https://proxy.golang.org
$ go get github.com/go-delve/[email protected]
go: downloading github.com/go-delve/liner v1.2.2-1
go: downloading github.com/mattn/go-runewidth v0.0.3
go: downloading golang.org/x/sys v0.0.0-20211117180635-dee7805ff2e1
go: added github.com/go-delve/liner v1.2.2-1
go: added github.com/mattn/go-runewidth v0.0.3
go: added golang.org/x/sys v0.0.0-20211117180635-dee7805ff2e1

Please verify and fix.

@pboguslawski pboguslawski reopened this Jun 2, 2022
@aarzilli
Copy link
Member

aarzilli commented Jun 2, 2022

cc @derekparker you have to make a tag

the module proxy and its consequences have been a disaster for cmd/go.

@bcmills
Copy link

bcmills commented Jun 2, 2022

Seems that after golang/go#51312 (comment) go does not treat branches with semantic-version names as releases.

To be precise, that behavior was changed for golang/go#35671, which was also backported to Go 1.16 and Go 1.17 as a minor security issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants