Test container before pushing to Docker registry #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
force-pushed
the
wip/obbardc/ci
branch
5 times, most recently
from
4a9be07
to
a5df438
Compare
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/ci
branch
2 times, most recently
from
de2b6c4
to
c3ea2c9
Compare
Building separate container images for each project was a bit of a premature optimisation which just made things more complicated. Instead of building separate containers for debos/fakemachine, build one generic container which may be used for either project. Since this renames the container image names, debos/fakemachine will need to be updated to use the new container images. No explicit dependency is required in the downstream projects since the old containers will remain in place as no deletion policy for these containers exists yet. Signed-off-by: Christopher Obbard <[email protected]>
We've been burnt before by pushing untested container images and then breaking debos/fakemachine CI jobs. Run the unit tests from the last tagged version of fakemachine/debos (which have already been tested) before pushing the container image to the registry. Fixes: #19 Signed-off-by: Christopher Obbard <[email protected]>
Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/ci
branch
from
c3ea2c9
to
b25be71
Compare
Signed-off-by: Christopher Obbard <[email protected]>
Signed-off-by: Christopher Obbard <[email protected]>
Signed-off-by: Christopher Obbard <[email protected]>
Signed-off-by: Christopher Obbard <[email protected]>
Signed-off-by: Christopher Obbard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been burnt before by pushing untested container images. Run the unit tests from the last tagged version of fakemachine/debos (which has already been tested) before pushing the container image to the registry as
:latest.