partitioning: Add partattrs property to partition #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obbardc
reviewed
Mar 19, 2024
sjoerdsimons
requested changes
Apr 15, 2024
actions/image_partition_action.go
Outdated
| @@ -58,6 +58,7 @@ a 32 bits hexadecimal number (e.g. '1234ABCD' without any dash separator). | |||
| fsck: bool | |||
| fsuuid: string | |||
| partuuid: string | |||
| partattrs: list of partition attributes | |||
There was a problem hiding this comment.
Suggested change
| partattrs: list of partition attributes | |
| partattrs: list of partition attributes bits to set |
Would be good to have the Verify function check it's only bit numbers in a valid range
There was a problem hiding this comment.
@nfraprado Just checking if you managed to look at adding a check in the Verify function for the bit range ? Please reach out if I can help to explain the comment above :-)
There was a problem hiding this comment.
Sorry for the delay. I've implemented verification now.
However I've noticed that bits 0-2 despite being documented in the specification and in the sfdisk man page, don't seem to be supported:
2024/05/31 19:42:27 sfdisk | unsupported GPT attribute bit '2'
2024/05/31 19:42:27 sfdisk | sfdisk: /dev/disk/by-fakemachine-label/fakedisk-0: partition 1: failed to set partition attributes
Should we forbid these values in verification too? Given it's documented it might be something specific to my setup. Unfortunately I don't have a lot of time to look into this.
Add a 'partattrs' property to partitions. It allows the GPT partition attribute bits to be set for a partition. Notably this is needed to set bits 48 and 56, which are part of the GUID specific range, to allow a ChromeOS Kernel partition to be booted on Chromebooks. Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a 'partattrs' property to partitions. It allows the GPT partition attribute bits to be set for a partition. Notably this is needed to set bits 48 and 56, which are part of the GUID specific range, to allow a ChromeOS Kernel partition to be booted on Chromebooks.