docs: update keepalive defaults, add default timeout config#63
Conversation
Reflect new sane defaults (idle: 300s, age: 1800s, grace: 30s) in config reference and production howto. Document -1 as opt-out sentinel for infinite connection lifetime.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded a new gRPC env var Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates ColdBrew documentation to reflect new gRPC server connection keepalive defaults and documents -1 as an opt-out sentinel for disabling keepalive limits, aligning docs with the companion core change.
Changes:
- Update gRPC keepalive defaults in the configuration reference (idle 300s, age 1800s, grace 30s) and document
-1opt-out. - Update the production guide to describe the new defaults and provide updated override examples (including a
-1disable example).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| howto/production.md | Updates production guidance and YAML examples for keepalive defaults and overrides. |
| config-reference.md | Updates keepalive defaults and adds -1 sentinel documentation in the config table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Change "disable (infinite)" to "disable this limit" and add note that both idle and age must be disabled for truly infinite connections.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove duplicate env var in keepalive example, use inline comment instead. Explicitly state "set to -1" in the infinite connections note.
Summary
Covers config reference and howto updates for two core changes being merged together:
Keepalive defaults (core#72)
GRPC_SERVER_MAX_CONNECTION_IDLE_IN_SECONDSdefault from0to300GRPC_SERVER_MAX_CONNECTION_AGE_IN_SECONDSdefault from0to1800GRPC_SERVER_MAX_CONNECTION_AGE_GRACE_IN_SECONDSdefault from0to30-1as opt-out for infinite lifetimeDefault timeout (core#73, interceptors#37)
GRPC_SERVER_DEFAULT_TIMEOUT_IN_SECONDS(default:60,0to disable) to config referenceTest plan
Summary by CodeRabbit