docs: update for native stats/opentelemetry migration#62
Conversation
… removal - config-reference: add OTEL_USE_LEGACY_INSTRUMENTATION, ENABLE_OTEL_METRICS, OTEL_METRICS_INTERVAL env vars; update OTLP_USE_OPENTRACING_BRIDGE as removed - integrations: remove UseOpenTracingBridge from OTLPConfig struct and examples - FAQ: update OpenTracing migration answer (bridge removed) - howto/Debugging: update otelgrpc.TagRPC reference to native stats handler
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation updated to remove the OpenTracing→OpenTelemetry bridge: migration guidance, config references, and examples now require native OpenTelemetry usage; Changes
Sequence Diagram(s)(none — changes are documentation and configuration updates without new cross-component runtime control flow requiring visualization.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates ColdBrew documentation to reflect the migration away from legacy OpenTracing bridge support and toward native OpenTelemetry instrumentation (incl. new metrics-related configuration).
Changes:
- Remove
UseOpenTracingBridgefromOTLPConfigstruct display and integrations examples. - Update OpenTracing→OpenTelemetry migration guidance in the FAQ to reflect bridge removal.
- Expand config reference with new OpenTelemetry env vars and clarify
OTLP_USE_OPENTRACING_BRIDGEis now ignored (warning-only), plus adjust debugging docs to reference the gRPC OTel stats handler.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| integrations.md | Removes deprecated bridge field from OTLPConfig docs and code examples. |
| howto/Debugging.md | Updates profiling table terminology from otelgrpc.TagRPC to the gRPC OTel stats handler. |
| FAQ.md | Revises migration guidance to reflect bridge removal and native OTel usage. |
| config-reference.md | Adds new OTel env vars and clarifies deprecated/ignored bridge env var behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
howto/Debugging.md (1)
68-68: Consider minor terminology consistency improvement.The table entry correctly replaces the deprecated
otelgrpc.TagRPCreference with the native stats handler. However,howto/Tracing.md(line 242-251) uses "OTEL gRPC stats handler" while this uses "gRPC OpenTelemetry stats handler". Both are correct, but consistent terminology across documentation files would improve clarity.📝 Optional consistency fix
To match the terminology in
howto/Tracing.md:-| gRPC OpenTelemetry stats handler | ~1% | OpenTelemetry span creation | +| OTEL gRPC stats handler | ~1% | OpenTelemetry span creation |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@howto/Debugging.md` at line 68, Update the terminology in the Debugging.md table row that currently reads "gRPC OpenTelemetry stats handler" to match the wording used in howto/Tracing.md ("OTEL gRPC stats handler") for consistency; locate the table row containing "gRPC OpenTelemetry stats handler" and replace that phrase with "OTEL gRPC stats handler" so both docs use the same term.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@howto/Debugging.md`:
- Line 68: Update the terminology in the Debugging.md table row that currently
reads "gRPC OpenTelemetry stats handler" to match the wording used in
howto/Tracing.md ("OTEL gRPC stats handler") for consistency; locate the table
row containing "gRPC OpenTelemetry stats handler" and replace that phrase with
"OTEL gRPC stats handler" so both docs use the same term.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 65c32daa-6684-4c8c-9c6e-eb471614538d
📒 Files selected for processing (4)
FAQ.mdconfig-reference.mdhowto/Debugging.mdintegrations.md
- FAQ: add tracer name argument to otel.Tracer() example - Debugging: update remaining otelgrpc reference to generic OTel terminology
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- howto/Metrics: new "OpenTelemetry Metrics (OTLP Export)" section with env vars, exported metric names, cardinality filtering, and comparison table showing how OTEL metrics relate to Prometheus - integrations: new "OpenTelemetry Metrics" section with config and usage - howto/production: add OTEL metrics config example in observability section
Summary
OTEL_USE_LEGACY_INSTRUMENTATION,ENABLE_OTEL_METRICS,OTEL_METRICS_INTERVALOTLP_USE_OPENTRACING_BRIDGEas removed (ignored with warning)UseOpenTracingBridgefromOTLPConfigstruct display and code examples in integrations pagehowto/Debugging.mdprofiling table — replaceotelgrpc.TagRPCwith native stats handlerCompanion to core migration in go-coldbrew/core (roadmap item 8.1).
Test plan
bundle exec jekyll serve)UseOpenTracingBridgeSummary by CodeRabbit
Documentation
Tests