Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last set of missing v5 paths #593

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Conversation

zikaeroh
Copy link
Contributor

@zikaeroh zikaeroh commented Feb 28, 2021

This fixes the paths that were missed in #561 (comment).

These _ prefixed folders are actually ignored by the Go tool when ran from an upper directory, so there's no imminent need. My comment was wrong, this is strictly for finishing the move.

Might be a good idea to add to the builder something that explicitly tries to build the files in _examples, to catch any errors.

@icholy
Copy link

icholy commented Mar 19, 2021

@zikaeroh I've added a path subcommand to gomajor to help with upgrades like this in the future.

# increment the major version
$ gomajor path -next

# set the major version
$ gomajor path -version=v7

# change the whole module path (if you decide to move the repo to avoid SIV)
$ gomajor path chisite.io/chi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants