Additional themes and changes to font and theme configuration API #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olorPalette These themes are a nice addition to the default, providing another light and dark color choice with red, yellow and other bright colors up front on the series. These themes are useful for any data where the initial items in the series should have the most emphasis. In addition the ColorPalette interface was changed to remove Set functions so that these structs will always only be read only.
jentfoo
changed the title
This includes the following changes for how Themes and Fonts are configured for charts: * The theme implementation has been updated to be colors only. Fonts and font sizes need to be communicated outside of the theme always. This allows the ColorPalette to be immutable. * Both the Theme ColorPalette and Font are set directly instead of setting names. This allows you to avoid the central font and theme store if you want. * As part of the above, the FontFamily has been removed (except for echarts where it is taken in from json). You need to set the font directly using GetFont(Family) instead. * The theme implementation has been updated to be thread safe. * Testing was expanded and updated to often be parallel. This is to help further validate no central store (like theme or fonts) have race conditions.
Default table settings will now be adjusted based on if the theme is light or dark. Any table setting adjustements outside of that need to be configured with the specific chart being rendered.
Because there is theme logic for every chart type, this updates the testing so that theme configuration is validated for all chart types as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two new themes and minor API changes around fonts and themes.
The added
vivid-lightandvivid-darkthemes provide bright series colors. The first colors being red, yellow, help highlight the importance of the first two series items.The full theme list is now
light,dark,vivid-light,vivid-dark,antandgrafana.API updates to how Themes and Fonts are configured for charts:
ColorPaletteto be immutable.ColorPaletteare set directly instead of setting names. This allows you to avoid the central font and theme store if you want. You need to useGetThemeorGetFontto convert the installed name into an instance for the chat configuration.FontFamilyhas been removed (except for echarts where it is taken in from json).SetDefaultTableSettingfunction has been removed. Default color logic has been improved to consider if the theme is dark or not, but any non-default settings will need to be specified in the options when creating the table.README will be updated later