Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAxis LabelCount is off by one #8

Open
jentfoo opened this issue Feb 12, 2024 · 1 comment
Open

XAxis LabelCount is off by one #8

jentfoo opened this issue Feb 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jentfoo
Copy link
Member

jentfoo commented Feb 12, 2024

It looks like an issue in the implementation from #3 exists where the config for the LabelCount and the actual label count are off by one. There is always one extra label printed than what is specifically configured.

@jentfoo jentfoo added the bug Something isn't working label Feb 12, 2024
@jentfoo jentfoo self-assigned this Feb 12, 2024
@jentfoo
Copy link
Member Author

jentfoo commented Feb 14, 2024

This seems to only happen with the line_chart-2 example. Smaller datasets behave correctly.

jentfoo added a commit that referenced this issue Feb 15, 2024
…labels

For implementations which may render a range of graphs, specifying a specific label count can be difficult.  The library already has complex logic to determine how many labels should be rendered.

Specifying an adjustment allows configuration of "Simpler" more spaced out graphs, while still allowing the specific label count to be dynamic based off the data inputs.

This commit serves as a work around to issue #8 (but specifying -1 if you're hitting this bug).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant