Skip to content

Strash index was always calculated at 0, leading to 100% collisions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ecordell wants to merge 2 commits into from
Closed

Strash index was always calculated at 0, leading to 100% collisions #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b733b79
add small go benchmark for sodoku
ecordell Aug 24, 2021
0cf6f83
strash index was always calculated at 0, leading to 100% collisions
ecordell Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions logic/c.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ func (p *C) And(a, b z.Lit) z.Lit {
return b
}
c := strashCode(a, b)
l := uint32(cap(p.nodes))
l := uint32(cap(p.nodes) - 1)
i := c % l
si := p.strash[i]
for {
Expand All @@ -282,7 +282,7 @@ func (p *C) And(a, b z.Lit) z.Lit {
m, j := p.newNode()
m.a = a
m.b = b
k := c % uint32(cap(p.nodes))
k := c % uint32(cap(p.nodes) - 1)
m.n = p.strash[k]
p.strash[k] = j
return z.Var(j).Pos()
Expand Down Expand Up @@ -367,7 +367,7 @@ func (p *C) grow() {
continue
}
c := strashCode(n.a, n.b)
j := c % ucap
j := c % (ucap - 1)
n.n = strash[j]
strash[j] = uint32(i)
}
Expand Down
7 changes: 7 additions & 0 deletions sudoku_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,18 @@ package gini_test

import (
"fmt"
"testing"

"github.com/go-air/gini"
"github.com/go-air/gini/z"
)

func BenchmarkSudoku(b *testing.B) {
for i := 0; i < b.N; i++ {
Example_sudoku()
}
}

func Example_sudoku() {
g := gini.New()
// 9 rows, 9 cols, 9 boxes, 9 numbers
Expand Down