feat: take out CNAME support from experimental features #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
feat/cname-out-experimental
branch
3 times, most recently
from
f1e55fe
to
b0b124f
Compare
ldez
force-pushed
the
feat/cname-out-experimental
branch
2 times, most recently
from
149394d
to
dc90586
Compare
ldez
force-pushed
the
feat/cname-out-experimental
branch
from
dc90586
to
d69f143
Compare
ldez
force-pushed
the
feat/cname-out-experimental
branch
2 times, most recently
from
32440af
to
f88f906
Compare
|
Windows... a file system with "ephemeral" errors and also with a dumb DNS resolving system... So I will try to understand and fix the problem but I think that I will be forced to keep the option only because Windows is a piece of s***. |
ldez
force-pushed
the
feat/cname-out-experimental
branch
11 times, most recently
from
c5fea6d
to
677f56d
Compare
ldez
force-pushed
the
feat/cname-out-experimental
branch
from
677f56d
to
307c53c
Compare
|
So I was forced to increase the DNS timeout only for Windows... |
dmke
approved these changes
Sep 19, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop
LEGO_EXPERIMENTAL_CNAME_SUPPORT