Skip to content

Conversation

@steven-7m
Copy link

Various changes to add Slackware 15.0 support to the gnustep-web-install procedure. The process requires the user to be setup in sudoers and will attempt to resolve any missing dependencies using slackpkg.

This is my first pull request, if any issues please let me know.

Various changes to add Slackware 15.0 support to the gnustep-web-install procedure.
The process requires the user to be setup in sudoers and will attempt to resolve any missing dependencies using slackpkg.
Copy link
Member

@ivucica ivucica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you rebase this, I don't see why this would not be mergeable.

@gcasa PTAL

else
echo "${USER} is already a member of sudo users."
fi
# Add to sudoers. slackware dependency install will prompt user to set it up
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this section optional, PTAL after rebasing

make debug=yes
sudo -E make GNUSTEP_INSTALLATION_DOMAIN=SYSTEM debug=yes install

echo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses #20, I like it

echo "================ Install Dependencies ================"
# Install dependencies
./tools-scripts/install-dependencies-${KERNEL}
./tools-scripts/install-dependencies-${KERNEL} || exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is partially addressing #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants