Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Left shift key equivalent modifier mask in xib unarchiver" #260

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Revert "Left shift key equivalent modifier mask in xib unarchiver" #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Source/GSXib5KeyedUnarchiver.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,7 +1395,7 @@ - (id) decodeModifierMaskForElement: (GSXibElement*)element
// Seems that Apple decided to omit this attribute IF certain default keys alone
// are applied. If this key is present WITH NO setting then the following is
// used for the modifier mask...
object = [NSNumber numberWithUnsignedInt: (NSCommandKeyMask << 8)];
object = [NSNumber numberWithUnsignedInt: NSCommandKeyMask];
}
}
else
Expand Down Expand Up @@ -1437,8 +1437,6 @@ - (id) decodeModifierMaskForElement: (GSXibElement*)element
mask |= NSFunctionKeyMask;
}

//This mask is left shifted 8 bits when encoded. When this is used to initialize the element, the mask will be shifted back to the right by 8 bits.
mask = (mask << 8);
object = [NSNumber numberWithUnsignedInt: mask];
}

Expand Down
Loading