docs(goose): add gnt integration guide - #138
Conversation
Signed-off-by: Ruiming Zhao <uuzzrm@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds Goose integration documentation for connecting to gnt-brain through MCP. It documents credential handling, instruction loading, verification, troubleshooting, and required authorization checks before side-effectful actions. ChangesGoose integration
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This documentation-only change adds a Goose integration guide and tool-use guidance without introducing runtime behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
integrations/goose/TOOLS.md (1)
3-4: 🔒 Security & Privacy | 🔵 TrivialEnforce and bind
check_actionoutside prompt text.This file is loaded as Goose hints or persistent instructions. Goose injects that text into model context; it does not itself prevent a model or another client from skipping
check_action. Confirm that the action executor or MCP gateway rejects side-effectful calls without a matching authorization check. Bind the approval to the exact recipient, amount, target, and scope so anallowedresult cannot be reused for a different action. (github.com)Also applies to: 11-19
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@integrations/goose/TOOLS.md` around lines 3 - 4, Update the action execution or MCP gateway path referenced by the Goose instructions to enforce check_action for every side-effectful call, rather than relying on prompt text. Require an allowed result bound to the exact recipient, amount, target, and scope of the requested action, and reject missing, mismatched, or reused authorization before execution.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@integrations/goose/CONNECT.md`:
- Around line 77-78: Update the troubleshooting guidance near the extension-load
instructions to state that GNT_MCP_KEY may be available either in Goose’s
inherited environment or its secret storage, with the environment checked first
and secret storage used as fallback. Retain the YAML indentation check and
warning not to include the raw key in bug reports.
- Around line 39-41: Update the GNT_MCP_KEY setup examples in CONNECT.md to
include equivalent PowerShell and cmd.exe commands alongside the existing Bash
form, or explicitly state that the examples require Bash; ensure Windows users
can set the variable using their native shells.
- Around line 15-28: Update the gnt-brain extension configuration to add an
explicit available_tools allowlist containing the five documented tools, while
preserving the existing check_action guidance in TOOLS.md and all other
connection settings.
---
Nitpick comments:
In `@integrations/goose/TOOLS.md`:
- Around line 3-4: Update the action execution or MCP gateway path referenced by
the Goose instructions to enforce check_action for every side-effectful call,
rather than relying on prompt text. Require an allowed result bound to the exact
recipient, amount, target, and scope of the requested action, and reject
missing, mismatched, or reused authorization before execution.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 11fea695-ffc0-439f-871b-20115afc1bff
📒 Files selected for processing (2)
integrations/goose/CONNECT.mdintegrations/goose/TOOLS.md
Signed-off-by: Ruiming Zhao <uuzzrm@gmail.com>
|
Thanks for the review. The configuration/documentation findings are addressed in
The focused documentation check passes for the five-tool allowlist, all three shell forms, the credential fallback, and the executor-boundary wording. One boundary is intentional: this PR only adds the Goose integration and its guidance. The gnt MCP server does not own Goose's downstream side-effect executor, so a documentation/configuration PR cannot enforce arbitrary external actions at that layer. |
What & why
Closes #81.
Add a Goose integration guide for gnt-brain’s remote MCP extension, including the current
streamable_httpconfig shape,env_keyssecret handling, and Goose’s.goosehints/ persistent-instructions options. The companionTOOLS.mdcarries the existingcheck_action-first policy so connecting the tools also documents when an agent must stop for a human verdict.Test plan
git diff --check; no credential-like literal was present.Before you open this
git commit -s) — seeCONTRIBUTING.md's DCO section.integrations/openclaw/.apps/cli/src/prebrain/extraction/, the PR description includes the recall/precision numbers frombun run eval:extraction -- --mode cloud. (Not applicable.)Summary by CodeRabbit