Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor transaction remove modal on edit route #394

Merged

Conversation

frontendphil
Copy link
Member

Relates to #389

Replace the old transaction modal mechanism with a new one. Also, we now use our own components for select controls and they are more accessible.

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 1:32pm

Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: 317114f
Status: ✅  Deploy successful!
Preview URL: https://123f013b.zodiac-pilot.pages.dev
Branch Preview URL: https://chore-refactor-transaction-r.zodiac-pilot.pages.dev

View logs

@frontendphil frontendphil force-pushed the chore/refactor-transaction-remove-modal-on-edit-route branch from af83676 to 317114f Compare December 18, 2024 13:31
Copy link

cloudflare-workers-and-pages bot commented Dec 18, 2024

Deploying zodiac-pilot with  Cloudflare Pages  Cloudflare Pages

Latest commit: 317114f
Status: ✅  Deploy successful!
Preview URL: https://c6ded099.zodiac-pilot-29m.pages.dev
Branch Preview URL: https://chore-refactor-transaction-r.zodiac-pilot-29m.pages.dev

View logs

Copy link

github-actions bot commented Dec 18, 2024

Coverage Report for extension

Status Category Percentage Covered / Total
🔵 Lines 63.63% 5372 / 8442
🔵 Statements 63.63% 5372 / 8442
🔵 Functions 70.72% 331 / 468
🔵 Branches 80.3% 840 / 1046
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
extension/src/components/inputs/Input.tsx 100% 80% 100% 100%
extension/src/components/inputs/Select.tsx 96.07% 100% 86.66% 96.07% 18, 20
extension/src/panel/pages/routes/edit.$routeId/AvatarInput.tsx 97.56% 92.3% 100% 97.56% 54, 57
extension/src/panel/pages/routes/edit.$routeId/EditRoute.tsx 84.93% 83.67% 63.15% 84.93% 117-118, 132-133, 268-269, 271-275, 330-336, 340-349, 367-374, 384, 388-396, 410-412
extension/src/panel/pages/routes/list/Route.tsx 97.14% 84.61% 100% 97.14% 50, 60
Generated in workflow #224 for commit 317114f by the Vitest Coverage Report Action

@frontendphil frontendphil enabled auto-merge (squash) December 18, 2024 13:34
@frontendphil frontendphil merged commit f131f51 into main Dec 18, 2024
12 checks passed
@frontendphil frontendphil deleted the chore/refactor-transaction-remove-modal-on-edit-route branch December 18, 2024 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant