Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure active route when deleting the currently active one #362

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

frontendphil
Copy link
Member

Fixes #351

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:00am

Copy link

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70fed13
Status: ✅  Deploy successful!
Preview URL: https://50a365bd.zodiac-pilot.pages.dev
Branch Preview URL: https://fix-error-when-deleting-acti.zodiac-pilot.pages.dev

View logs

Copy link

Deploying zodiac-pilot with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70fed13
Status: ✅  Deploy successful!
Preview URL: https://4ad11037.zodiac-pilot-29m.pages.dev
Branch Preview URL: https://fix-error-when-deleting-acti.zodiac-pilot-29m.pages.dev

View logs

Copy link

Coverage Report for extension

Status Category Percentage Covered / Total
🔵 Lines 63.16% 5245 / 8303
🔵 Statements 63.16% 5245 / 8303
🔵 Functions 71.45% 328 / 459
🔵 Branches 78.35% 789 / 1007
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
extension/src/panel/pages/routes/edit.$routeId/EditRoute.tsx 83.65% 69.56% 70.58% 83.65% 116-117, 131-132, 267-268, 270-274, 336-342, 346-355, 373-380, 390, 394-402, 416-418, 431, 436-438
Generated in workflow #127 for commit 70fed13 by the Vitest Coverage Report Action

@frontendphil frontendphil enabled auto-merge (squash) December 16, 2024 10:01
@frontendphil frontendphil merged commit 93adc0d into main Dec 16, 2024
12 checks passed
@frontendphil frontendphil deleted the fix/error-when-deleting-active-route branch December 16, 2024 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when deleting currently active route
1 participant