Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when executing as safe owner without mod #356

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

jfschwarz
Copy link
Collaborator

once ready, closes #352

Copy link

vercel bot commented Dec 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 4:45pm

Copy link

cloudflare-workers-and-pages bot commented Dec 14, 2024

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: ed0e004
Status: ✅  Deploy successful!
Preview URL: https://b0cbe914.zodiac-pilot.pages.dev
Branch Preview URL: https://fix-direct-exec.zodiac-pilot.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Dec 14, 2024

Deploying zodiac-pilot with  Cloudflare Pages  Cloudflare Pages

Latest commit: ed0e004
Status: ✅  Deploy successful!
Preview URL: https://fed8bb73.zodiac-pilot-29m.pages.dev
Branch Preview URL: https://fix-direct-exec.zodiac-pilot-29m.pages.dev

View logs

Copy link

github-actions bot commented Dec 14, 2024

Coverage Report for extension

Status Category Percentage Covered / Total
🔵 Lines 63.14% 5245 / 8306
🔵 Statements 63.14% 5245 / 8306
🔵 Functions 71.45% 328 / 459
🔵 Branches 78.35% 789 / 1007
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
extension/src/panel/pages/$activeRouteId/transactions/Submit.tsx 13.66% 33.33% 25% 13.66% 38-141, 146-152, 160-165, 178-204
Generated in workflow #172 for commit ed0e004 by the Vitest Coverage Report Action

@frontendphil
Copy link
Member

@jfschwarz, I fixed the import issue in ser-kit, and we're getting another issue.

CleanShot 2024-12-16 at 14 18 06

@jfschwarz jfschwarz merged commit 492f7be into main Dec 16, 2024
12 checks passed
@jfschwarz jfschwarz deleted the fix-direct-exec branch December 16, 2024 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Direct execution through Safe owner is not working
2 participants