Test of sibling block malice#60
Closed
vkomenda wants to merge 7 commits into
Closed
Conversation
vkomenda
force-pushed
the
vk-sibling-blocks
branch
from
f510a7b to
16e74db
Compare
Contributor
|
We have tested that manually and ensured it works fine. We won't add an integration test for that because the second validator's node does not always try to produce a block exactly the same time as the first node, so the integration test wouldn't know how much time it would take. The discussion about that is here: poanetwork/parity-ethereum#196 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an integration test for poanetwork/parity-ethereum#165.