Fix/warm coinbase and push0 checks#2
Merged
stdevMac merged 8 commits intofeat/add-withdrawals-sync-testfrom Jun 30, 2023
Merged
Fix/warm coinbase and push0 checks#2stdevMac merged 8 commits intofeat/add-withdrawals-sync-testfrom
stdevMac merged 8 commits intofeat/add-withdrawals-sync-testfrom
Conversation
stdevMac
approved these changes
Jun 30, 2023
Collaborator
stdevMac
left a comment
stdevMac
left a comment
There was a problem hiding this comment.
Just some comments to remove, but let's move that to when we get to merge the neth branch to the main branch while cleaning up, Good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue with contracts storage checks and comparisons before/after the shapella hardfork.
PR add helper
Accountsetters and getters to add contract accounts togenesis.Contracts bytecode added to check that such
EIPsare not applied before the hardfork and applied and works correctly after the hardfork:see docstring for the contract explanation
see docstring for the contract explanation