Merged
Conversation
cb3a06f to
f408ed1
Compare
stdevMac
approved these changes
Jul 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses implementation of
WithdrawalsExecutionLayerSpecalong with specs responsibility separation.Current
WithdrawalsBaseSpecinclude only protocol level checks to make sureshanghaiis activated and withdrawals are applied and executed correctly as system operations.Other checks like claims execution, balance change and transfer events ERC20 consistency lies in the
WithdrawalsExecutionLayerSpecscope.Changes:
ERC20 balancechecksWithdrawalsBaseSpecand added toWithdrawalsExecutionLayerSpecto separate specs responsibilitylibgnoto interact with a smart contractswithdrawals/test.go