Skip to content

feat/withdrawals execution layer spec#13

Merged
stdevMac merged 9 commits intomasterfrom
feat/withdrawals-execution-layer-spec
Jul 23, 2023
Merged

feat/withdrawals execution layer spec#13
stdevMac merged 9 commits intomasterfrom
feat/withdrawals-execution-layer-spec

Conversation

@4rgon4ut
Copy link

@4rgon4ut 4rgon4ut commented Jul 20, 2023

This PR addresses implementation of WithdrawalsExecutionLayerSpec along with specs responsibility separation.
Current WithdrawalsBaseSpec include only protocol level checks to make sure shanghai is activated and withdrawals are applied and executed correctly as system operations.
Other checks like claims execution, balance change and transfer events ERC20 consistency lies in the WithdrawalsExecutionLayerSpec scope.

Changes:

  • Fixed execution layer events and ERC20 balance checks
  • Execution layer logic removed from the WithdrawalsBaseSpec and added to WithdrawalsExecutionLayerSpec to separate specs responsibility
  • New functions added to libgno to interact with a smart contracts
  • Little refactoring and cleanup in withdrawals/test.go

@4rgon4ut 4rgon4ut force-pushed the feat/withdrawals-execution-layer-spec branch from cb3a06f to f408ed1 Compare July 21, 2023 13:46
@4rgon4ut 4rgon4ut requested a review from stdevMac July 21, 2023 15:35
@4rgon4ut 4rgon4ut marked this pull request as ready for review July 21, 2023 15:35
@stdevMac stdevMac merged commit 000f985 into master Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments