Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update cached deposits #25

Merged
merged 6 commits into from
Sep 5, 2023
Merged

feat: update cached deposits #25

merged 6 commits into from
Sep 5, 2023

Conversation

filoozom
Copy link
Contributor

@filoozom filoozom commented Sep 4, 2023

This adds a script to update the cached deposits. It also:

  • Adds support for multiple networks
  • Implements a retry strategy
  • Updates the cached deposits before each deployment

This supersedes #19 and should in general be simpler and more efficient.

Probably requires a few more tweaks down the line (better error handling?), but the project as a whole needs some serious work, so this will come bit by bit.

Closes #19

@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 10:49 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 10:52 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 10:59 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 12:14 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 12:27 Inactive
Copy link
Contributor

@4rgon4ut 4rgon4ut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good job! Dropped down one optional comment.

src/scripts/update-deposits.js Show resolved Hide resolved
@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 12:34 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 12:42 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 12:49 Inactive
@filoozom filoozom force-pushed the feat/update-deposits-script branch from ff7dc08 to 32a686c Compare September 4, 2023 12:59
@giacomolicari giacomolicari temporarily deployed to pr-review-feat-update-d-xphllv September 4, 2023 12:59 Inactive
@filoozom filoozom mentioned this pull request Sep 4, 2023
@dapplion dapplion merged commit 2ab6f30 into main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants