chore: fix all solhint issues#49
Merged
dapplion merged 3 commits intognosischain:withdrawals-pullfrom Jul 4, 2023
Merged
Conversation
filoozom
force-pushed
the
chore/fix-import-statements
branch
2 times, most recently
from
8f47a23 to
c52f0d9
Compare
filoozom
force-pushed
the
chore/fix-import-statements
branch
from
c52f0d9 to
2329b39
Compare
dapplion
requested changes
Jun 28, 2023
| */ | ||
| function executeSystemWithdrawals( | ||
| uint256 _deprecatedUnused, | ||
| uint256 /* _deprecatedUnused */, |
Member
There was a problem hiding this comment.
Unrelated diff, please revert lines 267 and 272
Contributor
Author
There was a problem hiding this comment.
Well, maybe I should rename the PR to "fix all solhint issues", which this does. Or do you still prefer reverting that?
Member
There was a problem hiding this comment.
Oh if solhint requires that change then all good 👍
Contributor
Author
There was a problem hiding this comment.
It does:
,Warning: Unused function parameter. Remove or comment out the variable name to silence this warning.
--> project:/contracts/SBCDepositContract.sol:273:9:
|
273 | uint256 _deprecatedUnused,
| ^^^^^^^^^^^^^^^^^^^^^^^^^
dapplion
reviewed
Jun 28, 2023
| * NOTE: This function signature is hardcoded in the Gnosis execution layer clients. Changing this signature without updating the | ||
| * clients will cause block verification of any post-shangai block to fail. The function signature cannonical spec is here | ||
| * https://github.com/gnosischain/specs/blob/master/execution/withdrawals.md | ||
| * @param _deprecatedUnused Previously `maxFailedWithdrawalsToProcess` currently deprecated and ignored |
Member
There was a problem hiding this comment.
Does solhint require to remove this line? If no, please keep. If yes, then convert to non param line we need the context of that that first variable refers to
Contributor
Author
There was a problem hiding this comment.
It does:
DocstringParsingError: Documented parameter "_deprecatedUnused" not found in the parameter list of the function.
--> project:/contracts/SBCDepositContract.sol:258:5:
|
258 | /**
| ^ (Relevant source part starts here and spans across multiple lines).
I'll convert it to non-@param.
filoozom
force-pushed
the
chore/fix-import-statements
branch
from
c7800b3 to
e1eb471
Compare
dapplion
approved these changes
Jul 4, 2023
dapplion
added a commit
that referenced
this pull request
Jul 11, 2023
* Withdrawals pull * Update maxFailedWithdrawalsToProcess variable name * Delete settings.json * Place all variables at the top * Update executeSystemWithdrawals comment * chore: fix all solhint issues (#49) * chore: remove global imports * chore: ignore _deprecatedUnused * chore: re-add _deprecatedUnused comment * chore: fix system tx inputs (#50) * chore: add system tx with right signature * fix: make signature public and fix tests * Update SBCDepositContract comment * Update SBCDepositContract.sol --------- Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com> --------- Co-authored-by: Philippe Schommers <philippe@schommers.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses named imports instead of global ones. Also fixes one tiny linting issue.