Skip to content

Skip bad withdrawals #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dapplion merged 2 commits into from
Mar 16, 2023
Merged

Skip bad withdrawals #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79e7f64
Skip bad withdrawals
dapplion Feb 25, 2023
7b8bdc1
Only drop address 0 withdrawal
dapplion Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions contracts/SBCDepositContract.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,12 @@ contract SBCDepositContract is
bool _unwrapToGNO,
uint256 gasLimit
) internal returns (bool success) {
// Skip withdrawal that burns tokens to avoid a revert condition
// https://github.com/OpenZeppelin/openzeppelin-contracts/blob/dad73159df3d3053c72b5e430fa8164330f18068/contracts/token/ERC20/ERC20.sol#L278
if (_receiver == address(0)) {
Copy link
Copy Markdown
Contributor

@Barichek Barichek Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is necessary? Burn of mGNO token will be done with account equal to address of withdrawals contract.

Copy link
Copy Markdown
Member Author

@dapplion dapplion Mar 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return true;
}

try this.processWithdrawalInternal{gas: gasLimit}(_amount, _receiver, _unwrapToGNO) {
return true;
} catch {
Expand Down