Skip to content

fix(examples): meta2#4228

Merged
jaekwon merged 86 commits intomasterfrom
fix/crossrealm/examples-integrations2
May 3, 2025
Merged

fix(examples): meta2#4228
jaekwon merged 86 commits intomasterfrom
fix/crossrealm/examples-integrations2

Conversation

@moul
Copy link
Member

@moul moul commented Apr 29, 2025

Continues #4211

Before starting to fix:

# go run github.com/gnolang/gno/gnovm/cmd/gno test ./... 2>&1 | grep -E '^FAIL.*gno.land'
FAIL    examples/gno.land/p/thox/accesscontrol 	0.07s
FAIL    examples/gno.land/r/demo/atomicswap 	0.09s
FAIL    examples/gno.land/r/demo/tests 	0.15s
FAIL    examples/gno.land/r/demo/wugnot 	0.12s
FAIL    examples/gno.land/r/gnoland/home 	0.12s
FAIL    examples/gno.land/r/gnoland/users 	0.06s
FAIL    examples/gno.land/r/gnoland/users/v1 	0.22s
FAIL    examples/gno.land/r/gnoland/valopers_proposal 	0.27s
FAIL    examples/gno.land/r/gov/dao 	0.06s
FAIL    examples/gno.land/r/gov/dao/v3/impl 	0.09s
FAIL    examples/gno.land/r/sys/names 	0.00s
FAIL    examples/gno.land/r/sys/params 	0.06s

EDIT: updated list

Signed-off-by: moul <94029+moul@users.noreply.github.com>
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Apr 29, 2025

🛠 PR Checks Summary

🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^docs/ (filename: docs/resources/gno-interrealm.md)

Then

🔴 Requirement not satisfied
└── 🔴 And
    ├── 🟢 Or
    │   ├── 🟢 Pull request author is a member of the team: tech-staff
    │   └── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request(with state "APPROVED")
    └── 🔴 Or
        ├── 🔴 Pull request author is a member of the team: devrels
        └── 🔴 At least 1 user(s) of the team devrels reviewed pull request(with state "APPROVED")

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@jefft0 jefft0 mentioned this pull request Apr 29, 2025
5 tasks
@aeddi
Copy link
Contributor

aeddi commented Apr 29, 2025

I still get the following error when I omit crossing() on the first line of a ⁠main function in a filetest:

unexpected panic: missing crossing() after cross call to main from gno.land/r/demo/main

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Apr 29, 2025
@jaekwon
Copy link
Contributor

jaekwon commented Apr 29, 2025

I still get the following error when I omit crossing() on the first line of a ⁠main function in a filetest:

unexpected panic: missing crossing() after cross call to main from gno.land/r/demo/main

Oh oops needs to not be called crossing anymore, "frame -1" handles it.
Can you see if my latest commit here fixes the problem?

@aeddi
Copy link
Contributor

aeddi commented Apr 29, 2025

Oh oops needs to not be called crossing anymore, "frame -1" handles it. Can you see if my latest commit here fixes the problem?

I just tested your commit and it looks like it is not yet fixed on the filetests.

--- FAIL: file/z_0_filetest.gno (0.26s)
unexpected panic: missing crossing() after cross call to main from gno.land/r/demo/main to gno.land/r/demo/main

I'm testing with:

cd examples/gno.land/r/demo/disperse
gno test -run=file/z_0_filetest.gno

Edit: Sorry, just realized I didn't rebuild gno cmd

moul and others added 4 commits May 3, 2025 11:39
@Gno2D2 Gno2D2 requested a review from a team May 3, 2025 11:44
moul added 5 commits May 3, 2025 13:53
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul moul force-pushed the fix/crossrealm/examples-integrations2 branch from e4c3ae6 to ab20dd9 Compare May 3, 2025 12:43
moul and others added 5 commits May 3, 2025 15:00
chore: r/gnoland/events
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@jaekwon jaekwon marked this pull request as ready for review May 3, 2025 20:12
@jaekwon jaekwon merged commit 9fac3f3 into master May 3, 2025
19 of 29 checks passed
@jaekwon jaekwon deleted the fix/crossrealm/examples-integrations2 branch May 3, 2025 20:12
@github-project-automation github-project-automation bot moved this from 📥 Inbox to ✅ Done in 😎 Manfred's Board May 3, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧙‍♂️Gno.land development May 3, 2025
@jaekwon jaekwon restored the fix/crossrealm/examples-integrations2 branch May 3, 2025 20:14
@jaekwon
Copy link
Contributor

jaekwon commented May 3, 2025

rebased onto master. #4244 meta3

@moul moul mentioned this pull request May 3, 2025
jaekwon added a commit that referenced this pull request May 5, 2025
Continues #4228

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: ltzMaxwell <ltz.maxwell@gmail.com>
Co-authored-by: moul <94029+moul@users.noreply.github.com>
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone May 5, 2025
stefann-01 pushed a commit to stefann-01/gno that referenced this pull request Jul 14, 2025
Continues gnolang#4228

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: ltzMaxwell <ltz.maxwell@gmail.com>
Co-authored-by: moul <94029+moul@users.noreply.github.com>
@thehowl thehowl deleted the fix/crossrealm/examples-integrations2 branch August 13, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.

Projects

Status: Done
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.