feat(gnofmt): delete trailing whitespaces#4214
Conversation
Signed-off-by: moul <94029+moul@users.noreply.github.com>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
I don't think it's a good idea because it manipulates strings. See examples/gno.land/r/mouss/home/home.gno. But this fix doesn't work because it manipulates declared string constants. |
Context: was working on #4211 and noticed that
make fmtandmake test.syncaren't compatible...This change may not be what we want, but I would like to propose it to gather opinions.
I believe that if we do not allow gnofmt to ignore trailing whitespaces, we should still expect this repository to adhere to this rule. Perhaps we could implement a second rule in "make fmt" that calls another binary.
In addition to reviewing my implementation, please share your thoughts.