fix(examples): restored expected behavior for Ownable#4207
Merged
gfanton merged 3 commits intognolang:fix/crossrealm/examples-integrationsfrom Apr 24, 2025
Merged
fix(examples): restored expected behavior for Ownable#4207gfanton merged 3 commits intognolang:fix/crossrealm/examples-integrationsfrom
gfanton merged 3 commits intognolang:fix/crossrealm/examples-integrationsfrom
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
leohhhn
reviewed
Apr 23, 2025
Contributor
leohhhn
left a comment
There was a problem hiding this comment.
Can you please completely revert the changes? Ie the names of the functions as well? 🙏
Member
Member
|
Merging in #4211 |
bb88a73
into
gnolang:fix/crossrealm/examples-integrations
14 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ownable had a regression in expected behavior when some calls were changed from
std.PreviousRealm()->std.CurrentRealm()This PR fixes the expected behavior of Ownable so that it uses
std.PreviousRealm()as it did before by fixing the tests so that they run within a CodeRealm context.This also fixes the failing tests for
gno.land/r/n2p5/mgroupthat were introduced after the recent change to Ownable.