Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: utilize p2p.ExternalAddress properly for dialing #3581

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zivkovicmilos
Copy link
Member

Description

This PR fixes a bug with the Transport bind address, where the bound address was taking in a wrong param, as part of an oversight.

It also adds context on the newly introduced checks.

@zivkovicmilos zivkovicmilos added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 22, 2025
@zivkovicmilos zivkovicmilos self-assigned this Jan 22, 2025
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jan 22, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 22, 2025

🛠 PR Checks Summary

🔴 Must not contain the "don't merge" label

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Must not contain the "don't merge" label

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Must not contain the "don't merge" label

If

🟢 Condition met
└── 🟢 A label matches this pattern: don't merge (label: don't merge)

Then

🔴 Requirement not satisfied
└── 🔴 On no pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jan 22, 2025
This reverts commit 29d5e0c.
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/bft/node/node.go 44.44% 12 Missing and 3 partials ⚠️
tm2/pkg/p2p/transport.go 54.54% 3 Missing and 2 partials ⚠️
tm2/pkg/internal/p2p/p2p.go 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@zivkovicmilos zivkovicmilos added the don't merge Please don't merge this functionality temporarily label Jan 22, 2025
@zivkovicmilos
Copy link
Member Author

Waiting on fix confirmation by @sw360cab and @mazzy89 before moving forward with the PR 🫡

@zivkovicmilos zivkovicmilos marked this pull request as ready for review January 22, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Please don't merge this functionality temporarily 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants