Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Block Protocol #241

Closed
wants to merge 3 commits into from
Closed

General Block Protocol #241

wants to merge 3 commits into from

Conversation

aria1th
Copy link

@aria1th aria1th commented Dec 31, 2021

Wallmounted / Wallskull is on WIP

Wallmounted / Wallskull is on WIP
How would you rotate coral fans, since it returns default coral? 🤷 
I'll let this as final, since it worked for several months...
@altrisi
Copy link
Collaborator

altrisi commented Jun 27, 2022

Question, was this and your other PR effectively superseded by #251? Or does this handle different features?

@aria1th
Copy link
Author

aria1th commented Jun 28, 2022

this handles rail shapes + chest attachment problem, I remember original code has problem with chest attachment : I'll check if double chest can be placed in current carpet first.

And..... door might have to be checked too, it has offset block removal bug, seems it can happen again

aria1th added a commit to aria1th/carpet-extra that referenced this pull request Jun 28, 2022
@altrisi
Copy link
Collaborator

altrisi commented Jul 27, 2022

Closing in favour of #267.

@altrisi altrisi closed this Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants