Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to anvil crushing rules #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manyrandomthings
Copy link
Contributor

  • renewableSand and renewableIce have been rewritten to be a bit simpler
  • renewableIce now supports setting the number of ice to crush with new rule renewableIceCrushCount
  • renewableIceCrushCount can be set to any value 1-9

@clarfonthey
Copy link

I wonder if it might be simpler to just make a generic anvil crushing recipe type, so that the result can be configured with data packs instead of requiring custom carpet settings. Would also have the benefit of being displayed in mods like REI.

@manyrandomthings manyrandomthings changed the base branch from 1.17 to master November 3, 2022 04:34
@altrisi altrisi self-requested a review November 3, 2022 09:10
@altrisi
Copy link
Collaborator

altrisi commented Nov 4, 2022

Wondering if it'd be nicer to instead have the renewableIce rule taking a number argument instead (it'd have to be a string for backwards compat, with true being 3 and false being off). Also wondering if there's a reason for the 9 count limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants