Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(V7) breaking: Latest Marked.js, React Native, and more #710

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

gmsgowtham
Copy link
Owner

@gmsgowtham gmsgowtham commented Sep 5, 2024

Breaking changes:

  • React native v0.76 or above required
  • Removed support for custom tokens in Tokenizer
  • CustomToken type removed, instead use Token or Tokens

Other:

  • Marked.js updated to latest
  • react-native-table-component is removed in favor of react-native-reanimated-table

@markwitt1
Copy link

What is the status on this one?

Copy link

github-actions bot commented Feb 1, 2025

Performance Comparison Report

  • Current: HEAD (97fd60d) - 2025-02-04 08:01:10Z
  • Baseline: main (8ce4310) - 2025-02-04 08:00:12Z

Significant Changes To Duration

Show entries
Name Type Duration Count
Perf test Renders markdown render 40.4 ms → 31.5 ms (-8.9 ms, -22.0%) 🟢 1 → 1
Show details
Name Type Duration Count
Perf test Renders markdown render Baseline
Mean: 40.4 ms
Stdev: 0.9 ms (2.3%)
Runs: 42.3 40.9 40.1 39.8 39.9 40.1 41.8 40.3 39.7 39.4
Warmup runs: 10040.1

Current
Mean: 31.5 ms
Stdev: 3.9 ms (12.2%)
Runs: 40.2 31.1 30.0 29.5 29.9 37.0 29.3 29.6 29.4 29.3
Warmup runs: 6104.4
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Render issues:

Meaningless Changes To Duration

There are no entries

Render Count Changes

There are no entries

Render Issues

There are no entries

Added Entries

There are no entries

Removed Entries

There are no entries

Generated by 🚫 dangerJS against 4d11eeb

@gmsgowtham gmsgowtham changed the title Marked next (V7) breaking: Latest Marked.js, React Native, and more Feb 1, 2025
@gmsgowtham gmsgowtham marked this pull request as ready for review February 1, 2025 14:53
@gmsgowtham gmsgowtham self-assigned this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants