Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why was node bumped to version 18? #367

Closed
efstathiosntonas opened this issue Jun 2, 2023 · 4 comments · Fixed by #369
Closed

Why was node bumped to version 18? #367

efstathiosntonas opened this issue Jun 2, 2023 · 4 comments · Fixed by #369
Labels
question Further information is requested

Comments

@efstathiosntonas
Copy link

Hi, thank you for this module. May I ask why node has been bumped to version 18? This is a breaking change for many devs.
@gmsgowtham
Copy link
Owner

gmsgowtham commented Jun 2, 2023 •
edited
Loading

Sorry if the latest release broke your development flow.

The reason is to support the latest release of marked https://github.com/markedjs/marked/releases/tag/v5.0.0

@gmsgowtham gmsgowtham added the question Further information is requested label Jun 2, 2023
@efstathiosntonas
Copy link
Author

efstathiosntonas commented Jun 2, 2023 •
edited
Loading

Thanks for the clarification, can you bump this to 18.16.0?

react-native-marked/package.json

Line 169 in 5972610

"node": ">=18 <=18.15.0"

gmsgowtham added a commit that referenced this issue Jun 2, 2023
@gmsgowtham
fix: loosen up node restriction
c011876 
ref: #367
@gmsgowtham gmsgowtham mentioned this issue Jun 2, 2023
Merged
@gmsgowtham gmsgowtham linked a pull request Jun 2, 2023 that will close this issue
fix: loosen up node restriction #369
Merged
@efstathiosntonas
Copy link
Author

thanks @gmsgowtham, keep it up!

@gmsgowtham
Copy link
Owner

It was my bad. v18.16.0 has an issue with Jest, so blindly restricted it to v18.15.0 😅

v5.0.2 Addressed it

@gmsgowtham gmsgowtham mentioned this issue Jun 18, 2023
Closed
@gmsgowtham gmsgowtham pinned this issue Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: loosen up node restriction gmsgowtham/react-native-marked
2 participants
@efstathiosntonas @gmsgowtham