Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rework serialization #7

Merged
merged 5 commits into from
Jan 22, 2024
Merged

feat: Rework serialization #7

merged 5 commits into from
Jan 22, 2024

Conversation

MichaelDark
Copy link
Contributor

Please, look at the CHANGELOG.md for the detailed list of changes.

@MichaelDark
Copy link
Contributor Author

@alexeyinkin This PR also resolves #6 (duplicates: #4, #5).

@gmpassos Looking forward to see these changes in pub.dev!

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc2499b) 100.00% compared to head (1f7cf2b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         3    +2     
  Lines           86        91    +5     
=========================================
+ Hits            86        91    +5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@gmpassos gmpassos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes and upgrades.

Best regards.

lib/src/yaml_writer_base.dart Outdated Show resolved Hide resolved
lib/src/node.dart Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@MichaelDark
Copy link
Contributor Author

Thanks for the review, @gmpassos.
All comments are resolved now.
Looking forward to see these changes in pub.dev!

@MichaelDark MichaelDark requested a review from gmpassos January 22, 2024 09:13
@gmpassos gmpassos merged commit c713cdc into gmpassos:master Jan 22, 2024
3 checks passed
@gmpassos
Copy link
Owner

Published:

yaml_writer 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants