Merge branch 'alerting/view-in-app' of github.com:gmmorris/kibana int…

…o alerting/view-in-app

* 'alerting/view-in-app' of github.com:gmmorris/kibana: (33 commits)
  [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950)
  [NP] Graph migration (elastic#59409)
  [ML] Clone analytics job  (elastic#59791)
  Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202)
  Handle improperly defined Watcher Logging Action text parameter. (elastic#60169)
  Move select range trigger to uiActions (elastic#60168)
  [SIEM][CASES] Configure cases: Final (elastic#59358)
  Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153)
  [siem/cypress] update junit filename to be picked up by runbld (elastic#60156)
  OSS logic added to test environment  (elastic#60134)
  Move canvas setup into app mount (elastic#59926)
  enable triggers_actions_ui plugin by default (elastic#60137)
  Expose Elasticsearch from start and deprecate from setup (elastic#59886)
  [SIEM] [Case] Insert timeline bugfix and limit 25 cases (elastic#60136)
  [ML] Client side cut over (elastic#60100)
  Disable query bar on service map routes (elastic#60118)
  Move subscribe_with_scope to kibana_legacy (elastic#59781)
  [Ingest] Agent Config create with sys monitoring (elastic#60111)
  [Watcher UI] Not possible to edit a watch that was created with the API if the ID contains a dot (elastic#59383)
  Actually fetch functionbeat fields needed for telemetry (elastic#60054)
  ...

.eslintrc.js

@@ -142,7 +142,7 @@ module.exports = {
       },
     },
     {
-      files: ['x-pack/legacy/plugins/ml/**/*.{js,ts,tsx}'],
+      files: ['x-pack/plugins/ml/**/*.{js,ts,tsx}'],
       rules: {
         'react-hooks/exhaustive-deps': 'off',
       },

.github/CODEOWNERS

@@ -26,7 +26,7 @@
 /src/plugins/kibana_legacy/ @elastic/kibana-app
 /src/plugins/timelion/ @elastic/kibana-app
 /src/plugins/dev_tools/ @elastic/kibana-app
-/src/plugins/dashboard_embeddable_container/ @elastic/kibana-app
+/src/plugins/dashboard/ @elastic/kibana-app
 
 # App Architecture
 /packages/kbn-interpreter/ @elastic/kibana-app-arch

.gitignore

@@ -4,7 +4,6 @@
 /.es
 .DS_Store
 .node_binaries
-.native_modules
 node_modules
 !/src/dev/npm/integration_tests/__fixtures__/fixture1/node_modules
 !/src/dev/notice/__fixtures__/node_modules

.i18nrc.json

@@ -3,7 +3,7 @@
     "common.ui": "src/legacy/ui",
     "console": "src/plugins/console",
     "core": "src/core",
-    "dashboardEmbeddableContainer": "src/plugins/dashboard_embeddable_container",
+    "dashboard": "src/plugins/dashboard",
     "data": [
       "src/legacy/core_plugins/data",
       "src/plugins/data"

CONTRIBUTING.md

@@ -171,6 +171,8 @@ Bootstrap Kibana and install all the dependencies
 yarn kbn bootstrap
 ```
 
+> Node.js native modules could be in use and node-gyp is the tool used to build them. There are tools you need to install per platform and python versions you need to be using. Please see https://github.com/nodejs/node-gyp#installation and follow the guide according your platform.
+
 (You can also run `yarn kbn` to see the other available commands. For more info about this tool, see https://github.com/elastic/kibana/tree/master/packages/kbn-pm.)
 
 When switching branches which use different versions of npm packages you may need to run;

docs/development/core/server/kibana-plugin-core-server.corestart.elasticsearch.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [CoreStart](./kibana-plugin-core-server.corestart.md) &gt; [elasticsearch](./kibana-plugin-core-server.corestart.elasticsearch.md)
+
+## CoreStart.elasticsearch property
+
+[ElasticsearchServiceStart](./kibana-plugin-core-server.elasticsearchservicestart.md)
+
+<b>Signature:</b>
+
+```typescript
+elasticsearch: ElasticsearchServiceStart;
+```

docs/development/core/server/kibana-plugin-core-server.corestart.md

@@ -17,6 +17,7 @@ export interface CoreStart
 |  Property | Type | Description |
 |  --- | --- | --- |
 |  [capabilities](./kibana-plugin-core-server.corestart.capabilities.md) | <code>CapabilitiesStart</code> | [CapabilitiesStart](./kibana-plugin-core-server.capabilitiesstart.md) |
+|  [elasticsearch](./kibana-plugin-core-server.corestart.elasticsearch.md) | <code>ElasticsearchServiceStart</code> | [ElasticsearchServiceStart](./kibana-plugin-core-server.elasticsearchservicestart.md) |
 |  [savedObjects](./kibana-plugin-core-server.corestart.savedobjects.md) | <code>SavedObjectsServiceStart</code> | [SavedObjectsServiceStart](./kibana-plugin-core-server.savedobjectsservicestart.md) |
 |  [uiSettings](./kibana-plugin-core-server.corestart.uisettings.md) | <code>UiSettingsServiceStart</code> | [UiSettingsServiceStart](./kibana-plugin-core-server.uisettingsservicestart.md) |
 

docs/development/core/server/kibana-plugin-core-server.elasticsearchservicesetup.adminclient.md

@@ -4,7 +4,12 @@
 
 ## ElasticsearchServiceSetup.adminClient property
 
-A client for the `admin` cluster. All Elasticsearch config value changes are processed under the hood. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.
+> Warning: This API is now obsolete.
+> 
+> Use [ElasticsearchServiceStart.legacy.client](./kibana-plugin-core-server.elasticsearchservicestart.legacy.md) instead.
+> 
+> A client for the `admin` cluster. All Elasticsearch config value changes are processed under the hood. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.
+> 
 
 <b>Signature:</b>
 

docs/development/core/server/kibana-plugin-core-server.elasticsearchservicesetup.createclient.md

@@ -4,7 +4,12 @@
 
 ## ElasticsearchServiceSetup.createClient property
 
-Create application specific Elasticsearch cluster API client with customized config. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.
+> Warning: This API is now obsolete.
+> 
+> Use [ElasticsearchServiceStart.legacy.createClient](./kibana-plugin-core-server.elasticsearchservicestart.legacy.md) instead.
+> 
+> Create application specific Elasticsearch cluster API client with customized config. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.
+> 
 
 <b>Signature:</b>
 

docs/development/core/server/kibana-plugin-core-server.elasticsearchservicesetup.dataclient.md

@@ -4,7 +4,12 @@
 
 ## ElasticsearchServiceSetup.dataClient property
 
-A client for the `data` cluster. All Elasticsearch config value changes are processed under the hood. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.
+> Warning: This API is now obsolete.
+> 
+> Use [ElasticsearchServiceStart.legacy.client](./kibana-plugin-core-server.elasticsearchservicestart.legacy.md) instead.
+> 
+> A client for the `data` cluster. All Elasticsearch config value changes are processed under the hood. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->.
+> 
 
 <b>Signature:</b>
 

docs/development/core/server/kibana-plugin-core-server.elasticsearchservicesetup.md

@@ -15,7 +15,7 @@ export interface ElasticsearchServiceSetup
 
 |  Property | Type | Description |
 |  --- | --- | --- |
-|  [adminClient](./kibana-plugin-core-server.elasticsearchservicesetup.adminclient.md) | <code>IClusterClient</code> | A client for the <code>admin</code> cluster. All Elasticsearch config value changes are processed under the hood. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->. |
-|  [createClient](./kibana-plugin-core-server.elasticsearchservicesetup.createclient.md) | <code>(type: string, clientConfig?: Partial&lt;ElasticsearchClientConfig&gt;) =&gt; ICustomClusterClient</code> | Create application specific Elasticsearch cluster API client with customized config. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->. |
-|  [dataClient](./kibana-plugin-core-server.elasticsearchservicesetup.dataclient.md) | <code>IClusterClient</code> | A client for the <code>data</code> cluster. All Elasticsearch config value changes are processed under the hood. See [IClusterClient](./kibana-plugin-core-server.iclusterclient.md)<!-- -->. |
+|  [adminClient](./kibana-plugin-core-server.elasticsearchservicesetup.adminclient.md) | <code>IClusterClient</code> |  |
+|  [createClient](./kibana-plugin-core-server.elasticsearchservicesetup.createclient.md) | <code>(type: string, clientConfig?: Partial&lt;ElasticsearchClientConfig&gt;) =&gt; ICustomClusterClient</code> |  |
+|  [dataClient](./kibana-plugin-core-server.elasticsearchservicesetup.dataclient.md) | <code>IClusterClient</code> |  |
 

docs/development/core/server/kibana-plugin-core-server.elasticsearchservicestart.legacy.md

@@ -0,0 +1,14 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [ElasticsearchServiceStart](./kibana-plugin-core-server.elasticsearchservicestart.md) &gt; [legacy](./kibana-plugin-core-server.elasticsearchservicestart.legacy.md)
+
+## ElasticsearchServiceStart.legacy property
+
+<b>Signature:</b>
+
+```typescript
+legacy: {
+        readonly createClient: (type: string, clientConfig?: Partial<ElasticsearchClientConfig>) => ICustomClusterClient;
+        readonly client: IClusterClient;
+    };
+```

docs/development/core/server/kibana-plugin-core-server.elasticsearchservicestart.md

@@ -0,0 +1,19 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [ElasticsearchServiceStart](./kibana-plugin-core-server.elasticsearchservicestart.md)
+
+## ElasticsearchServiceStart interface
+
+
+<b>Signature:</b>
+
+```typescript
+export interface ElasticsearchServiceStart 
+```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [legacy](./kibana-plugin-core-server.elasticsearchservicestart.legacy.md) | <code>{</code><br/><code>        readonly createClient: (type: string, clientConfig?: Partial&lt;ElasticsearchClientConfig&gt;) =&gt; ICustomClusterClient;</code><br/><code>        readonly client: IClusterClient;</code><br/><code>    }</code> |  |
+

docs/development/core/server/kibana-plugin-core-server.md

@@ -74,6 +74,7 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
 |  [DiscoveredPlugin](./kibana-plugin-core-server.discoveredplugin.md) | Small container object used to expose information about discovered plugins that may or may not have been started. |
 |  [ElasticsearchError](./kibana-plugin-core-server.elasticsearcherror.md) |  |
 |  [ElasticsearchServiceSetup](./kibana-plugin-core-server.elasticsearchservicesetup.md) |  |
+|  [ElasticsearchServiceStart](./kibana-plugin-core-server.elasticsearchservicestart.md) |  |
 |  [EnvironmentMode](./kibana-plugin-core-server.environmentmode.md) |  |
 |  [ErrorHttpResponseOptions](./kibana-plugin-core-server.errorhttpresponseoptions.md) | HTTP response parameters |
 |  [FakeRequest](./kibana-plugin-core-server.fakerequest.md) | Fake request object created manually by Kibana plugins. |

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.agggroupnames.md

@@ -0,0 +1,15 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggGroupNames](./kibana-plugin-plugins-data-public.agggroupnames.md)
+
+## AggGroupNames variable
+
+<b>Signature:</b>
+
+```typescript
+AggGroupNames: Readonly<{
+    Buckets: "buckets";
+    Metrics: "metrics";
+    None: "none";
+}>
+```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparam.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParam](./kibana-plugin-plugins-data-public.aggparam.md)
+
+## AggParam type
+
+<b>Signature:</b>
+
+```typescript
+export declare type AggParam = BaseParamType;
+```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparamoption.display.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParamOption](./kibana-plugin-plugins-data-public.aggparamoption.md) &gt; [display](./kibana-plugin-plugins-data-public.aggparamoption.display.md)
+
+## AggParamOption.display property
+
+<b>Signature:</b>
+
+```typescript
+display: string;
+```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparamoption.enabled.md

@@ -0,0 +1,22 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParamOption](./kibana-plugin-plugins-data-public.aggparamoption.md) &gt; [enabled](./kibana-plugin-plugins-data-public.aggparamoption.enabled.md)
+
+## AggParamOption.enabled() method
+
+<b>Signature:</b>
+
+```typescript
+enabled?(agg: AggConfig): boolean;
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  agg | <code>AggConfig</code> |  |
+
+<b>Returns:</b>
+
+`boolean`
+

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparamoption.md

@@ -0,0 +1,25 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParamOption](./kibana-plugin-plugins-data-public.aggparamoption.md)
+
+## AggParamOption interface
+
+<b>Signature:</b>
+
+```typescript
+export interface AggParamOption 
+```
+
+## Properties
+
+|  Property | Type | Description |
+|  --- | --- | --- |
+|  [display](./kibana-plugin-plugins-data-public.aggparamoption.display.md) | <code>string</code> |  |
+|  [val](./kibana-plugin-plugins-data-public.aggparamoption.val.md) | <code>string</code> |  |
+
+## Methods
+
+|  Method | Description |
+|  --- | --- |
+|  [enabled(agg)](./kibana-plugin-plugins-data-public.aggparamoption.enabled.md) |  |
+

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparamoption.val.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParamOption](./kibana-plugin-plugins-data-public.aggparamoption.md) &gt; [val](./kibana-plugin-plugins-data-public.aggparamoption.val.md)
+
+## AggParamOption.val property
+
+<b>Signature:</b>
+
+```typescript
+val: string;
+```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparamtype._constructor_.md

@@ -0,0 +1,20 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParamType](./kibana-plugin-plugins-data-public.aggparamtype.md) &gt; [(constructor)](./kibana-plugin-plugins-data-public.aggparamtype._constructor_.md)
+
+## AggParamType.(constructor)
+
+Constructs a new instance of the `AggParamType` class
+
+<b>Signature:</b>
+
+```typescript
+constructor(config: Record<string, any>);
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  config | <code>Record&lt;string, any&gt;</code> |  |
+

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparamtype.allowedaggs.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParamType](./kibana-plugin-plugins-data-public.aggparamtype.md) &gt; [allowedAggs](./kibana-plugin-plugins-data-public.aggparamtype.allowedaggs.md)
+
+## AggParamType.allowedAggs property
+
+<b>Signature:</b>
+
+```typescript
+allowedAggs: string[];
+```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparamtype.makeagg.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParamType](./kibana-plugin-plugins-data-public.aggparamtype.md) &gt; [makeAgg](./kibana-plugin-plugins-data-public.aggparamtype.makeagg.md)
+
+## AggParamType.makeAgg property
+
+<b>Signature:</b>
+
+```typescript
+makeAgg: (agg: TAggConfig, state?: any) => TAggConfig;
+```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggparamtype.md

@@ -0,0 +1,25 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggParamType](./kibana-plugin-plugins-data-public.aggparamtype.md)
+
+## AggParamType class
+
+<b>Signature:</b>
+
+```typescript
+export declare class AggParamType<TAggConfig extends IAggConfig = IAggConfig> extends BaseParamType<TAggConfig> 
+```
+
+## Constructors
+
+|  Constructor | Modifiers | Description |
+|  --- | --- | --- |
+|  [(constructor)(config)](./kibana-plugin-plugins-data-public.aggparamtype._constructor_.md) |  | Constructs a new instance of the <code>AggParamType</code> class |
+
+## Properties
+
+|  Property | Modifiers | Type | Description |
+|  --- | --- | --- | --- |
+|  [allowedAggs](./kibana-plugin-plugins-data-public.aggparamtype.allowedaggs.md) |  | <code>string[]</code> |  |
+|  [makeAgg](./kibana-plugin-plugins-data-public.aggparamtype.makeagg.md) |  | <code>(agg: TAggConfig, state?: any) =&gt; TAggConfig</code> |  |
+

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggtypefieldfilters.addfilter.md

@@ -0,0 +1,24 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggTypeFieldFilters](./kibana-plugin-plugins-data-public.aggtypefieldfilters.md) &gt; [addFilter](./kibana-plugin-plugins-data-public.aggtypefieldfilters.addfilter.md)
+
+## AggTypeFieldFilters.addFilter() method
+
+Register a new  with this registry. This will be used by the .
+
+<b>Signature:</b>
+
+```typescript
+addFilter(filter: AggTypeFieldFilter): void;
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  filter | <code>AggTypeFieldFilter</code> |  |
+
+<b>Returns:</b>
+
+`void`
+

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.aggtypefieldfilters.filter.md

@@ -0,0 +1,25 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [AggTypeFieldFilters](./kibana-plugin-plugins-data-public.aggtypefieldfilters.md) &gt; [filter](./kibana-plugin-plugins-data-public.aggtypefieldfilters.filter.md)
+
+## AggTypeFieldFilters.filter() method
+
+Returns the  filtered by all registered filters.
+
+<b>Signature:</b>
+
+```typescript
+filter(fields: IndexPatternField[], aggConfig: IAggConfig): IndexPatternField[];
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  fields | <code>IndexPatternField[]</code> |  |
+|  aggConfig | <code>IAggConfig</code> |  |
+
+<b>Returns:</b>
+
+`IndexPatternField[]`
+