Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support archive/must-gather files compressed with XZ #168

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jun 10, 2024

Creating support of must-gather files compressed with XZ.

@mtulio
Copy link
Contributor Author

mtulio commented Jun 10, 2024

Hey @gmeghnag do you think supporting XZ compressed files can contribute to the project? I am working in projects which we are compressing must-gather with XZ to distributed across CI results with smaller files (sometimes 5x+). Having omc support of reading xz compressed must-gather archives will help to decrease steps while reading those files using that amazing tool. Looking forward to hear from you if it makes sense. Local tests works file.

I opened #169 applying gofmt to decrease the changes while reading this PR. Feel free to suggest alternatives.

Thanks.

@gmeghnag
Copy link
Owner

@mtulio "do you think supporting XZ compressed files can contribute to the project?"
Sure! I see the tests are failing, could you please check why? We need the test to pass before approving the PR, thanks!

@mtulio
Copy link
Contributor Author

mtulio commented Jul 6, 2024

@mtulio "do you think supporting XZ compressed files can contribute to the project?" Sure! I see the tests are failing, could you please check why? We need the test to pass before approving the PR, thanks!

Hi @gmeghnag, thanks for your feedback. Rebased/Fixed. Would you mind taking a look?

/assign gmeghnag

@gmeghnag gmeghnag merged commit 63cfc53 into gmeghnag:main Jul 8, 2024
1 check passed
@mtulio mtulio deleted the support-xz branch July 25, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants