Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Removed reflection on Kotlin binding" #124

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

gmazzo
Copy link
Owner

@gmazzo gmazzo commented Jan 12, 2024

This partially reverts #101 to maximize the compatibility with complex build setups.

As per the general rule classpath should be consistent and interesting plugins should be added in the same classpath, there is a special use case we want to support:

Given the following structure:

  • buildSrc/src/main/kotlin/my-constants.gradle.kts -> uses this plugin to create some constants
  • build.gradle.kts -> applies my-constants and the koltin plugin.

Without this reflection logic, you'll be forced to promote the koltin plugin as well to the buildSrc classpath.

@gmazzo gmazzo force-pushed the readd-reflection-for-kotlin branch from b45c10e to ca38fae Compare January 12, 2024 16:32
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (7017e60) 15.70% compared to head (ca38fae) 15.63%.

❗ Current head ca38fae differs from pull request most recent head e43360b. Consider uploading reports for the commit e43360b to get more accurate results

Files Patch % Lines
...zzo/buildconfig/internal/bindings/KotlinHandler.kt 0.00% 7 Missing ⚠️
...ig/internal/bindings/KotlinMultiplatformHandler.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #124      +/-   ##
============================================
- Coverage     15.70%   15.63%   -0.08%     
  Complexity       13       13              
============================================
  Files            19       19              
  Lines           643      646       +3     
  Branches        171      171              
============================================
  Hits            101      101              
- Misses          525      528       +3     
  Partials         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmazzo gmazzo force-pushed the readd-reflection-for-kotlin branch from ca38fae to e43360b Compare January 12, 2024 16:34
@gmazzo gmazzo enabled auto-merge (rebase) January 12, 2024 16:34
@gmazzo gmazzo merged commit febf67d into main Jan 12, 2024
3 checks passed
@gmazzo gmazzo deleted the readd-reflection-for-kotlin branch January 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant